Skip to content

Correct attached route group path example - #213

Merged
harikt merged 1 commit into
auraphp:3.xfrom
dajiaohuang:docs/fix-route-group-path-example
Oct 31, 2026
Merged

harikt merged 1 commit into
auraphp:3.xfrom
dajiaohuang:docs/fix-route-group-path-example

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Correct the attached route-group example: Map::put('add', '') under the /blog prefix generates /blog, not /blog/{id}.
  • Documentation-only; no runtime behavior changed.

Validation

  • Confirmed against Map::attach() and route path-prefix handling; MapTest also covers attached path prefixes (not executed).
  • git diff --check passed.
  • PHP and Composer are unavailable in this environment; no tests were run.

Summary by CodeRabbit

  • Documentation
    • Updated the documented effective path for blog.add to /blog.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b48ffa9b-a08c-4587-b2ed-2f4e563f4108
Commits

Reviewing files that changed from the base of the PR and between d5cc315 and 5a73e05.

Files selected for processing: 1
  • docs/attaching-route-groups.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The route-group documentation now lists /blog as the effective path for blog.add, replacing /blog/{id}.

Changes: Route Group Documentation

Layer / File(s) Summary
Document the effective route path
docs/attaching-route-groups.md
The documented blog.add route path changed from /blog/{id} to /blog.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: Minimal · up to 5a73e

No actionable merge-blocking risk remains for this documentation-only change.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Correct attached route group path example" matches the change. The only modified file is docs/attaching-route-groups.md, with one line changed. The documented effective path for blog.add ch…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Correct attached route group path example" matches the change. The only modified file is docs/attaching-route-groups.md, with one line changed. The documented effective path for blog.add changes from /blog/{id} to /blog, which matches the PR objective of correcting the Map::put('add', '') example under the /blog prefix. The title is specific and concise, and it names the primary change: a documentation fix to the attached route group path example.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harikt
harikt merged commit e23b925 into auraphp:3.x Oct 31, 2026
13 of 14 checks passed
@harikt

harikt commented Oct 31, 2026

Copy link
Copy Markdown
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants