Repository navigation
feat: indicate dependent property when required error is triggered by dependencies (#181) - #344
Open
utkarshpatwa393-sys wants to merge 1 commit into
Conversation
… dependencies (atlassian#181) Signed-off-by: Utkarsh patwa <utkarshpatwa393@gmail.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #181.
Summary of Changes
When a schema specifies
dependenciesordependentRequiredwhere propertyArequires propertyB, Ajv generates arequirederror withschemaPath: #/dependencies/A/required. Previously,RequiredValidationErroronly reportedmust have required property 'B', leaving users unclear as to why propertyBwas suddenly required (as propertyBis not globally required on the parent object).This PR:
schemaPathinRequiredValidationError.☹️ contentFile is missing here (required by 'raw')!must have required property 'contentFile' (required by 'raw')DefaultValidationErrorfor directdependencieskeyword errors to avoid awkward keyword prefixing.