Repository navigation
fix: prioritize specific child errors over branch required errors in anyOf (#153) - #342
Open
utkarshpatwa393-sys wants to merge 1 commit into
Open
utkarshpatwa393-sys wants to merge 1 commit into
utkarshpatwa393-sys wants to merge 1 commit into
Conversation
…ssian#153) Signed-off-by: Utkarsh patwa <utkarshpatwa393@gmail.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153 (and addresses #81).
Summary of Changes
When validating against an
anyOforoneOfschema where an unselected branch specifiesrequiredproperties, Ajv emitsrequirederrors at the parent node alongsideanyOferrors. Previously,filterRedundantErrorstreated allrequirederrors as having absolute priority over child errors, emptyingroot.childrenand masking specific validation errors (e.g.,type,enum, etc.) on properties that the user actually provided in their payload.This PR:
requirederrors from branch-specificrequirederrors (schemaPathcontaining/anyOf/or/oneOf/).requirederrors coexist with child errors from alternative branches.requirederrors are retained as expected.anyOffailure resolution.All existing and new tests pass cleanly with 100% typecheck and lint conformance.