Repository navigation
Pin Windows image version in CI - #17190
Merged
Merged
Conversation
nikola-matic
marked this pull request as ready for review
November 6, 2026 10:16
blishko
approved these changes
Nov 6, 2026
blishko
left a comment
blishko
left a comment
Contributor
There was a problem hiding this comment.
I think it's OK to pin the version for now, but at some point we will have to figure out how to upgrade, no?
Contributor
Author
Yes, this will require bumping our boost version (currently 1.83 IIRC). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started getting failures on b_win this morning - turns out our Windows images aren't pinned, and an update from a couple of weeks ago introduced a new version that does away with older VC toolsets, which then causes boost install to fail. This was working until last night due the old dependencies being cached.