Repository navigation
Scripts: Fix incorrect check when preparing bytecode report summary - #17189
Merged
Merged
Conversation
The iteration over the list was incorrect, it was checking if the elements of the list are None, while it is suppose to check if the `bytecode` and `metadata` fields of the elements are None.
nikola-matic
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iteration over the list was incorrect, it was checking if the elements of the list are
None, while it is supposed to check if thebytecodeandmetadatafields of the elements areNone.The elements are instances of
ContractReportand the fixed version corresponds to whatformat_reportdoes.AI Disclosure
This was found by Opus 5.5.