Repository navigation
Remove abicoderv1 pragma - #17187
Merged
Merged
Remove abicoderv1 pragma#17187
Conversation
nikola-matic
force-pushed
the
remove-abicoderv1-pragma
branch
from
November 5, 2026 13:45
2bc4c5c to
e02a8b1
Compare
nikola-matic
marked this pull request as ready for review
November 5, 2026 13:50
blishko
reviewed
Nov 5, 2026
blishko
left a comment
blishko
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I have a few questions.
blishko
reviewed
Nov 6, 2026
blishko
left a comment
blishko
left a comment
Contributor
There was a problem hiding this comment.
Can you fix the typo and put the changelog entry in the proper place? Then we can merge.
nikola-matic
force-pushed
the
remove-abicoderv1-pragma
branch
from
November 6, 2026 08:15
e02a8b1 to
f797b9b
Compare
blishko
approved these changes
Nov 6, 2026
nikola-matic
force-pushed
the
remove-abicoderv1-pragma
branch
from
November 6, 2026 10:27
f797b9b to
0facb0f
Compare
blishko
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the abicoder v1 pragma and adjusted the tests and the CI accordingly. I also adjusted the docs which now only mention abicoder v2, although some of that will also have to be reworded/removed once we drop abicoder v2 pragma, since at that point, there will be no need to have this distinction once that pragma is gone.
There's quite a bit of dead code, which I'll address in a follow up PR.
Also had to fix ext_brink due to pragma abicoder v1 usages, but fortunately just getting rid of them allows the tests to pass.
Fixes #11323