Repository navigation
Conversation
Contributor
Author
|
cc @cameel |
Collaborator
|
I wonder if we should also include the I guess maybe it's fine. If you put them together you do get a full schema without duplication and the point of the split was exactly that separation... |
Contributor
Author
Yeah, I think it’s fine as-is. The compilation schema doesn’t define a stamp and the combined |
Stop embedding the compilation record in resource outputs for Solidity and Yul. Keep compiler information and sources in the independently requested compilation output. Match the C++ model to the schema optional field. Update help, docs and test expectations, and cover separate and combined output selection.
djolertrk
force-pushed
the
fix/ethdebug-overlap
branch
from
November 7, 2026 19:54
4b523e1 to
67cedbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove compilation data from ethdebug.resources, since it is already available through ethdebug.compilation. Update the docs and tests accordingly.