Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private functions passed to
make_closurestill need their original definitions and call signatures. These passes previously updated direct calls only and could remove or replace a function while leaving its closure reference behind.InlinePrivateFunctions;ExpandTupleArguments;RemoveUnusedParameters.The three passes share a small internal reference collector. Functions used only by direct calls remain eligible for the existing optimizations.
Closes #20593
Closes #20653
Closes #20654
Tests:
pytest tests/python/relax/test_transform_inline_private_functions.py tests/python/relax/test_transform_expand_tuple_args.py tests/python/relax/test_transform_remove_unused_parameters.py -q: 12 passed, including the existing direct-call and recursion controls.