Repository navigation
Move to Go 1.26 floor with Go 1.27 tested, verify plugin hook points and refresh framework ranges - #260
Merged
Conversation
wu-sheng
force-pushed
the
bump/go-1.26-floor-1.27-ci
branch
3 times, most recently
from
October 18, 2026 07:39
b847e08 to
1cc0ab9
Compare
…and refresh framework ranges Go 1.25 reached end of life with the Go 1.27 release. Go versions: - Every project module declares go 1.26.0. The floor stays below 1.27 because the agent's go directive becomes the minimum for every application that imports it, and Go 1.26 is still supported. - CI, plugin/e2e/Windows jobs, and the published base images move to Go 1.26 and Go 1.27. - golang.org/x/net moves to v0.61.0, which closes the HTTP/2 advisories left open by #258, along with the other x/* modules. - golangci-lint v2.15.0, installed from golangci-lint.run/install.sh. Older copies of the script pick the SBOM checksum and fail for every release since v2.12.2. Plugin test harness: - Build each scenario case with GOWORK=off. Minimal version selection across go.work lifted the framework to the newest version required by any plugin or scenario module, so most cases did not build the version they were named after. - The go-elasticsearch and goframe scenarios declare the full module path, so their version matrix applies. cross-goroutine uses the local toolkit. kratosv2 runs in CI again, and one failing scenario no longer cancels the others. Plugins: - Every plugin module requires the newest framework version whose hook-point signatures match the last tested version, and each scenario tests that version on Go 1.26 and Go 1.27. - Lower bounds rise where older versions never worked or never built: dubbo-go v3.0.2, kratos v2.6.3, go-micro v4.9.0, gorm v1.25.1, and go-sql-driver/mysql v1.5.0. - grpc v1.84.0 is handled by a new plugins/grpc-v184, and dubbo-go v3.3.1 by a new plugins/dubbo-v331, since both releases changed the internals the interceptors are compiled against. The existing plugins keep older releases and builds whose version cannot be detected. - amqp also intercepts PublishWithDeferredConfirm, which Publish and PublishWithContext reach since amqp091-go v1.10.0, and injected headers reach messages published with nil Headers. - go-redis no longer traces the connection setup commands that run through the client hooks since v9.9.0; HELLO and AUTH exported the password in span tags. - zap reports after the pre-write hooks of v1.28.0, and logrus no longer panics on entries with nil Data. - The skywalking-go-agent binary has no reachable third-party advisories left (go-git, go-billy, circl, amqp091-go). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ej1HubxqebgChKygA5TTHP
wu-sheng
force-pushed
the
bump/go-1.26-floor-1.27-ci
branch
from
October 18, 2026 08:04
1cc0ab9 to
4ba21d4
Compare
wu-sheng
marked this pull request as ready for review
October 18, 2026 08:35
CodePrometheus
approved these changes
Oct 18, 2026
This was referenced Oct 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.25 reached end of life with the Go 1.27 release. This PR moves every module to
go 1.26.0, tests on Go 1.26 and Go 1.27, verifies every plugin's hook points against new framework versions, and sets new verified version ranges.Go versions
go 1.26.0in every project module. The floor is not 1.27, because the agent'sgodirective becomes the minimum for every application that imports it, and Go 1.26 is still supported upstream.go1.26/go1.27.golang.org/x/netv0.61.0 closes the HTTP/2 advisories that Bump grpc to v1.83.2 and x/net to v0.58.0 to fix known CVEs #258 left open, together withx/textv0.43.0 and the otherx/*modules.https://golangci-lint.run/install.sh. Older copies of the install script pick the SBOM checksum and fail for every release since v2.12.2.Hook-point verification
protocol→basetype aliases.Test harness fixes
GOWORK=off. Minimal version selection acrossgo.worklifted the framework to the newest version required by any plugin or scenario module, so about two thirds of the cases did not build the version they were named after./v8,/v2), so their version matrix applies.fail-fast: false: one failing scenario no longer cancels the others.api.proto.Plugins
plugins/grpc-v184, which reports the same spans as before.plugins/dubbo-v331, since v3.3.1's graceful-shutdown filter importsprotocol/baseandprotocol/resultinstead ofprotocol.net/http, so its entry span is created by the http plugin.PublishWithDeferredConfirm, whichPublishandPublishWithContextgo through since amqp091-go v1.10.0. Injected headers now reach messages published with nilHeaders.HELLOandAUTHexported the password in span tags. The same commands are also skipped when the application sends them itself.Data(v1.10.0+).docs/en/agent/support-plugins.md. CHANGES.md lists every version that is no longer supported and why. None of them was dropped because Go 1.26 cannot build it.Agent binary
govulncheck reports no reachable third-party advisories in
skywalking-go-agent(go-git, go-billy, circl and amqp091-go were fixed).Review by an external model
The squashed diff was reviewed by an external model (read-only source review). I verified each finding against the framework source:
RecvMsgand does not finish the stream, so the plugin marks the receive span and the stream's exit span with the error and finishes the stream span once. Unit tests cover both cases.CLIENT TRACKING, sent during connection setup when client-side caching is enabled, is filtered with the other setup commands.net/httpin v3.3.0. The docs no longer date that change to v3.3.1.main: a framework replaced by a local module reports no version, so the existingplugins/grpc/plugins/dubbois used. A local dubbo-go v3.3.1+ therefore does not compile with the agent, which is the same as before this PR. Choosing the plugin from the package source instead of the version needs an agent change, and is left for a follow-up.Verification
go testpasses in all 36 modules on Go 1.26.9.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ej1HubxqebgChKygA5TTHP