Repository navigation
HDDS-15886. Use block length from datanode for under-construction block in StreamBlockInputStream - #11551
Draft
chungen0126 wants to merge 2 commits into
Draft
HDDS-15886. Use block length from datanode for under-construction block in StreamBlockInputStream#11551chungen0126 wants to merge 2 commits into
chungen0126 wants to merge 2 commits into
Conversation
…ck in StreamBlockInputStream Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
With
ozone.client.stream.read.blockenabled, a reader can't read all hsync'ed data of a file that is still being written. It hits EOF at the block length OM last recorded, which can be stale for the last block becausehsyncKeyonly updates OM when the last block changes.BlockInputStreamhandles this by getting the real length from the datanode for an under-construction block;StreamBlockInputStreamdid not.This PR passes the under-construction flag to
StreamBlockInputStream. Before the first read, the stream sends oneGetBlockto get the real length, using the existing retry handling. Other blocks send no extra RPC.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15886
How was this patch tested?
TestStreamBlockInputStream.TestOzoneContractFSOwithstreamReadBlockenabled:testSyncablefails before this change and passes after. It also passes withstreamReadBlockdisabled.Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code