Repository navigation
Improved: Require full-suite regression testing, not component-scoped, in manage-contribution-workflow - #486
Merged
mridulpathak merged 2 commits intoOct 30, 2026
Conversation
…age-contribution-workflow A clean component-scoped test run doesn't prove other components or plugins that internally call into the changed code still work, since a userLogin that was fine before a functional change may not satisfy whatever the change now requires. This has broken internal callers in unrelated framework components and, separately, in a plugins repository that a codebase grep could never find. Documents running the full suite (no component filter) as the default verification step, with codebase grep as a useful but non-substitute first pass.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A component-scoped ofbiz --test run (or a codebase grep for callers) doesn't prove a functional change is safe — other components, and even the plugins/ repository, can call into the changed code internally with a userLogin that doesn't satisfy a new requirement, and a grep inside applications/ can't find a dependency living in a different repository. Documents running the full regression suite (no component filter) as the default verification step for any functional change, with the codebase grep kept only as a useful first pass.