Skip to content

Fix six samples that can't run in a standard installation, fixes #9406 - #9407

Merged
bamaer merged 1 commit into
apache:mainfrom
Adalennis:9406
Nov 10, 2026
Merged

bamaer merged 1 commit into
apache:mainfrom
Adalennis:9406

Conversation

@Adalennis

Copy link
Copy Markdown
Contributor

Fixes #9406

  • dataset-input.hpl reads the data set run-pipeline-tests-input, which the samples project already has, and its note says so.
  • dataset-output.hpl writes to its own data set dataset-output with "Recreate data set" on, so the first run creates the data set and its CSV file.
  • execute-unit-tests.hpl runs the unit test run-pipeline-tests-unit.
  • execution-information.hpl gets a Data grid with the "include children" and "limit" fields that "Get execution IDs" requires, and the samples project gets the execution information location local it uses (a File location in ${HOP_AUDIT_FOLDER}/executions/, as local-audit in the default project). The type and name fields, which this operation doesn't use, are cleared.
  • data-stream-input.hpl and data-stream-output.hpl move to the Apache Arrow plugin, next to the sample-data-stream metadata they use, so they are only installed with that plugin.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bamaer

bamaer commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Thanks @Adalennis, LGTM.

We ran all six samples with hop-run in a scratch copy of the samples project. They run without errors, and run-pipeline-tests-unit passes. We didn't run the Maven build or a marketplace install of Arrow.

@bamaer
bamaer merged commit db6c9ec into apache:main Nov 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Six samples can't run in a standard installation: missing data sets, unit test, execution information location and data stream

2 participants