Repository navigation
[CALCITE-7863] AggregateReduceFunctionsOnGroupKeysRule fails for constant aggregates on empty input - #5336
Open
xiedeyantu wants to merge 1 commit into
Open
[CALCITE-7863] AggregateReduceFunctionsOnGroupKeysRule fails for constant aggregates on empty input#5336xiedeyantu wants to merge 1 commit into
xiedeyantu wants to merge 1 commit into
Conversation
…tant aggregates on empty input
xuzifu666
approved these changes
Oct 16, 2026
|
julianhyde
reviewed
Oct 16, 2026
| if (!Aggregate.isSimple(aggregate)) { | ||
| return null; | ||
| } | ||
| // A global aggregate may return NULL on empty input even when its |
Contributor
There was a problem hiding this comment.
Aggregate functions don't always return NULL on empty input. For example COUNT returns 0.
Is there an interface on SqlFunction that reports the value an aggregate function returns on empty input?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7863
Changes Proposed
See CALCITE-7863