Repository navigation
Fix malformed CSV in generate_samplesheet.py when paths contain commas - #1378
Closed
08raviyadav wants to merge 1 commit into
Closed
08raviyadav wants to merge 1 commit into
08raviyadav wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your interest! This repo only accepts contributions from Anthropic team members. If you'd like to submit a plugin to the marketplace, please submit your plugin here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1296:
generate_samplesheet.pyreported success but wrote a malformed samplesheet whenever a FASTQ path contained a comma (for example, reads stored in areads,run/directory).Cause
_write_samplesheet()assembled rows with','.join(values), so a comma inside any value became a field separator. With a comma in the input directory, the 4-column rnaseq header was followed by a 6-field data row, and the tool's own--validatethen rejected the file it had just written (missing FASTQ paths, invalidstrandedness).Change
bio-research/skills/nextflow-development/scripts/generate_samplesheet.pyonly:csv.writer(minimal quoting,\nline terminator to keep the existing file format). Values containing commas are now quoted as single fields; values without special characters are written exactly as before.Verification
Reproduced the issue steps locally, before and after the change:
--validatefails (exit 1).--validatepasses ("Samplesheet is valid for rnaseq").