Repository navigation
fix(eval): reject ambiguous task IDs before comparing results - #3609
Open
linyuchao123 wants to merge 1 commit into
Open
linyuchao123 wants to merge 1 commit into
linyuchao123 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Two tasks with the same ID can silently hide a regression. With baseline scores
[True, True]and current scores[False, True], the overall pass rate drops to 50%, butRunResult.diff()maps tasks by ID and keeps only the last task, reporting 100% to 100% with no regressions.Validate non-empty string IDs and uniqueness in
SuiteandRunResult. This also rejects collisions between explicit IDs and generated IDs, and ambiguous historical JSON runs loaded throughload_run. Missing/null IDs still receive the existing sequential defaults; explicit IDs are never silently renamed. Errors identify the source, duplicated ID, and task indices.Validation:
python -m pytest test/eval -q --disable-warnings: 332 passed, 6 skipped (optional dependencies).git diff --checkpassed for the changed files.Related issue number
No directly corresponding open issue found. This is separate from #3401, which addresses unpaired scorer denominators rather than duplicate task identity.
Checks
AI assistance
AI assistance was used for investigation, implementation, regression tests, and this description. Local validation and comparison with the original implementation are recorded above. The human-ownership attestations below are left for the contributor to complete after personal review.