Repository navigation
Plan 035 — WordPress.org pre-submission fixes - #44
Merged
Merged
Conversation
…eview; zip check fails on its text or link
…ialog, test-email route, uninstall removes user meta by prefix
…ation; Extensions block only for extensions with errors
…rid); the preview's order pick reads a sample-need registry
…ls back to the build); one install at a time
…s, literal hook names, dismissible requirements notice
… exit; wp-env-min maps a vendor without dev packages
…t always uses the saved test address
…a mismatched x.y.z version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
src/lite/teaser.ts=null, revert f077316 after approval).check-lite-zip.sh(flagTEASER_HIDDEN) fails if the teaser text or link is inassets/distor the.pot; the.pot's Plugin URI header entry, which is the same address, is left out of that check.FieldDialog. Saved in user metayaymatik_test_emailbyPOST yaymatik/v1/test-email(manage_woocommerce,is_email, 400 with a message).send-testsends to the saved address, else the profile email (Email/TestRecipient::of()). Localizedwp.testEmailreplaceswp.userEmail. Uninstall (remove all data) deletesyaymatik_%and_yaymatik_%user meta.Cleanup::ensure()skips its hourly wait when the daily job list changed (yaymatik_cleanup_jobs), and aDailyJobsjob can say it has no work (needed): the sweep has none without an active Customer inactive workflow, so Health shows no row and no fix for it.Pro/Workflow/Core/Email/OrderGrid). The freeEmailPreviewpicks the preview order through a small@internalregistry (add_sample_need( $kind, $tag, $has )) that Pro fills.RegisterDev.phpbefore the classmap dump; both zip checks fail if the classmap names it;RegisterFacadefalls back to the built assets whenYAYMATIK_IS_DEVELOPMENTis set but the file is gone.Schema::maybe_install()runs one load at a time (add_optionlockyaymatik_db_installing, taken over after 60 s).NotPreparedcode inRunStore::delete_with_steps); hook names are literals (yaymatik_modules,yaymatik_resendable_emails,yaymatik_change_role_allow_all; the constants are gone); the requirements notice is dismissible.release.shhas one EXIT cleanup: Pro bundle back, temp excludes file gone, normalcomposer dump-autoload.check-all --wp-env-minfrom a dev checkout: the PHP 7.4 site maps avendor/without dev packages (built indev/wp-env-min/build,.wp-env.override.json, both gitignored) over the plugin's; it rebuilds whencomposer.json/composer.lockchange and restarts the site once.check-editionis skipped there (it accepts--wp-envonly).WC tested up to: 11.3; wp-env runs WooCommerce 11.3.0.Tested up to: 7.1stays: 7.1.4 is the latest WordPress.Commits
.potVersion:back to 1.0.0 (CP8 committed a stray1.0).potwith the 1.0.0 headerrecipientwoocommerce_add_to_cart_validationinRestoreCartResults
check-all --wp-envcheck-all --wp-env-minthecodingmachine/safe)release/yaymatik.zip,release/yaymatik-pro.zip1.0.0-rc433, both from 8be7610check-lite-zip.sh.potentry and aRegisterDevclassmap entry)Baseline note: the baseline
check-all --wp-envand e2e ran while CP1 / CP2 edits were in the working tree; release and Plugin Check baselines were built from a clean worktree at 6c9fe6f. e2e runs inmcr.microsoft.com/playwright:v1.64.1-noble(Playwright 1.64 has no macOS 12 build).WordPress.org review notes
Schema::in()/about()/filter(); values go throughprepare().woocommerce_add_to_cart_validationinRestoreCart: WooCommerce's own filter, applied as its add-to-cart form does, so other plugins can refuse a product when a cart is restored (WC_Cart::add_to_cart()doesn't apply it). TheNonPrefixedHooknameFoundignore says so.Other findings
doing_it_wrong_runlogger: the YayMatik page, Settings, Dashboard, Plugins, shop, a product page and home logged nothing. The local site'sdebug.loghas no such notice either. No change.release/yaymatik.zipinstalled in place of the checkout and a fresh login, the YayMatik page answers 200 in the Playwright browser and the app mounts. The 036 403 did not reproduce; likely the auth state saved before the swap. Not committed (a spec would need to swap the plugin and restore it around the Pro suite).Browser check for Jack
Open questions
add_sample_need()takes the kind as well as the tag ($kind, $tag, $has): the client'ssampleProductsnames the kind (cross_sells).