Skip to content

Plan 035 — WordPress.org pre-submission fixes - #44

Merged
jack9x merged 16 commits into
developfrom
jack/feature/035-wporg-presubmit
Nov 18, 2026
Merged

jack9x merged 16 commits into
developfrom
jack/feature/035-wporg-presubmit

Conversation

@jack9x

@jack9x jack9x commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

What changes

  • T0 The free edition hides its "Get YayMatik Pro" teaser for the 1.0 review (src/lite/teaser.ts = null, revert f077316 after approval). check-lite-zip.sh (flag TEASER_HIDDEN) fails if the teaser text or link is in assets/dist or the .pot; the .pot's Plugin URI header entry, which is the same address, is left out of that check.
  • E1 Send test goes to a per-user address: a pencil on "Test goes to …" (hover and keyboard focus) opens "Send test to", the Rename workflow dialog made into one shared FieldDialog. Saved in user meta yaymatik_test_email by POST yaymatik/v1/test-email (manage_woocommerce, is_email, 400 with a message). send-test sends to the saved address, else the profile email (Email/TestRecipient::of()). Localized wp.testEmail replaces wp.userEmail. Uninstall (remove all data) deletes yaymatik_% and _yaymatik_% user meta.
  • F8 No inactive-sweep false alarm after a license activation: Cleanup::ensure() skips its hourly wait when the daily job list changed (yaymatik_cleanup_jobs), and a DailyJobs job can say it has no work (needed): the sweep has none without an active Customer inactive workflow, so Health shows no row and no fix for it.
  • F9 Health's Extensions block lists only extensions with errors, and is gone when none has any.
  • F1 Order cross-sell / upsell grids move to Pro (Pro/Workflow/Core/Email/OrderGrid). The free EmailPreview picks the preview order through a small @internal registry (add_sample_need( $kind, $tag, $has )) that Pro fills.
  • F4 The release deletes RegisterDev.php before the classmap dump; both zip checks fail if the classmap names it; RegisterFacade falls back to the built assets when YAYMATIK_IS_DEVELOPMENT is set but the file is gone.
  • F5 Schema::maybe_install() runs one load at a time (add_option lock yaymatik_db_installing, taken over after 60 s).
  • T1 / G5 Plugin Check: SQL ignores name the reported sniffs (and the wrong NotPrepared code in RunStore::delete_with_steps); hook names are literals (yaymatik_modules, yaymatik_resendable_emails, yaymatik_change_role_allow_all; the constants are gone); the requirements notice is dismissible.
  • F2 release.sh has one EXIT cleanup: Pro bundle back, temp excludes file gone, normal composer dump-autoload.
  • MIN check-all --wp-env-min from a dev checkout: the PHP 7.4 site maps a vendor/ without dev packages (built in dev/wp-env-min/build, .wp-env.override.json, both gitignored) over the plugin's; it rebuilds when composer.json / composer.lock change and restarts the site once. check-edition is skipped there (it accepts --wp-env only).
  • HDR WC tested up to: 11.3; wp-env runs WooCommerce 11.3.0. Tested up to: 7.1 stays: 7.1.4 is the latest WordPress.

Commits

CP Hash What
CP0 — Baseline only, no change
CP1 f077316 T0
CP2 bca8cff E1
CP3 78dc2ee F8 + F9
CP4 b3e8cff F1
CP5 7177a8e F4 + F5 (F6: no change)
CP6 241ce67 T1 + G5
fix 474065c phpcs on the CP2 / CP3 test stand-ins
CP7 25b2427 F2 + MIN
CP8 393a888 HDR
CP9 0b872c7 .pot
fix 82c0cbd Version: back to 1.0.0 (CP8 committed a stray 1.0)
fix 516e1bc .pot with the 1.0.0 header
fix a0411bf + fe4c7a7 Newest-customer preview breaks same-second ties on the higher id (and check-lifecycle's query too); send-test drops recipient
fix 8be7610 Plugin Check ignore for woocommerce_add_to_cart_validation in RestoreCart

Results

Baseline (6c9fe6f) Final (8be7610)
PHPUnit Pro / Lite 1084 / 886 1096 / 895 (two grid tests moved to Pro)
Vitest Pro / Lite 537 + 1 skipped / 427 + 23 skipped 540 + 1 skipped / 431 + 23 skipped
lint / lint:php / build pass (3 eslint warnings) / 0 / pass same
check-all --wp-env 14/14 after the tie-break fix: 14/14 twice
check-all --wp-env-min fails at start (PHP 7.4 parse error in thecodingmachine/safe) 12 pass, 1 skip (check-edition), 1 flaky fail (check-lifecycle, passed alone)
e2e (Pro, Docker) 11/11 11/11
Plugin Check, free zip 0 errors / 35 warnings 0 errors / 0 warnings
Zips — release/yaymatik.zip, release/yaymatik-pro.zip 1.0.0-rc433, both from 8be7610
check-lite-zip.sh pass pass (also fails on planted teaser text, link, .pot entry and a RegisterDev classmap entry)

Baseline note: the baseline check-all --wp-env and e2e ran while CP1 / CP2 edits were in the working tree; release and Plugin Check baselines were built from a clean worktree at 6c9fe6f. e2e runs in mcr.microsoft.com/playwright:v1.64.1-noble (Playwright 1.64 has no macOS 12 build).

WordPress.org review notes

  • SQL: every interpolated fragment is a fixed string or placeholders built by Schema::in() / about() / filter(); values go through prepare().
  • woocommerce_add_to_cart_validation in RestoreCart: WooCommerce's own filter, applied as its add-to-cart form does, so other plugins can refuse a product when a cart is restored (WC_Cart::add_to_cart() doesn't apply it). The NonPrefixedHooknameFound ignore says so.

Other findings

  • F6 "woocommerce domain loaded too early": not reproduced. wp-env (WordPress 7.1.4, WooCommerce 11.2.2, WP_DEBUG on, only WooCommerce + YayMatik active, Pro and Lite) with a doing_it_wrong_run logger: the YayMatik page, Settings, Dashboard, Plugins, shop, a product page and home logged nothing. The local site's debug.log has no such notice either. No change.
  • F3 Free-zip browser smoke: with release/yaymatik.zip installed in place of the checkout and a fresh login, the YayMatik page answers 200 in the Playwright browser and the app mounts. The 036 403 did not reproduce; likely the auth state saved before the swap. Not committed (a spec would need to swap the plugin and restore it around the Pro suite).
  • F7 not done (optional, last).
  • gitleaks: not installed, not run.

Browser check for Jack

  1. Free zip on a clean site: the template library shows 8 templates and no PRO group; the trigger and action pickers show 9 and 6 steps and no PRO group.
  2. Send email step: hover "Test goes to …" → pencil → dialog like Rename workflow. An invalid address shows the error under the field. A valid one saves, the line changes, Send test arrives there. Reload keeps it; another admin still sees their own address.
  3. Pro: install, activate the license → Health check shows no inactive-sweep row (no Customer inactive workflow). Create and activate Win-back → the row's check is ok and the job is scheduled without waiting an hour.
  4. Health check with acme-rewards active and fine → no Extensions block. Make it fail → the block shows acme only.

Open questions

  1. add_sample_need() takes the kind as well as the tag ($kind, $tag, $has): the client's sampleProducts names the kind (cross_sells).

…ialog, test-email route, uninstall removes user meta by prefix
…ation; Extensions block only for extensions with errors
…rid); the preview's order pick reads a sample-need registry
…s, literal hook names, dismissible requirements notice
… exit; wp-env-min maps a vendor without dev packages
@jack9x
jack9x merged commit 8025d34 into develop Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant