Repository navigation
feat: plan 032 — M9 release hardening for WordPress.org: free zip, lifecycle, light-only admin, test targets - #39
Merged
Merged
Conversation
…ist and /wp-review
…ation and the real user_collides(), late-module temp file readable and ignored
… workflow on a failed save; e2e waits for the dialog to close
…ion and uninstall, check-plugin-lifecycle
…notices, targeted option cache deletes, RCs of the minimums accepted
…the license client
…ee zip (LegacyBridge needs it), Pro adapter out through .distignore, sed failures stop the build
…empty state and run detail polish, inline core logos, scoped preflight
…d, e2e for settings, health fix, classic checkout and unsubscribe
…ck runs, daily job times restored, unsubscribe test with a control shopper, classic checkout waits for the order review
… the active copy's data, only SVG data URIs as logos, no dead WooCommerce guard, readme on waiting runs after a reinstall
…no names that shadow WordPress globals
…guarded, checked), composer.json shipped, jsx-runtime external, escaped exceptions, ABSPATH guards
…eState, stricter guard check (aliases, dependent classes, guard must name a License class), ABSPATH guards in the Pro zip too
…uses means no orders, refunds_sql() back, upsert test, tidy
…log visibility respected
…ckorders kept, one catalog rule, order lines primed, overflow counts items
…ke the preflight; WordPress's menu and bar untouched
…ed, stricter guard and ABSPATH checks, pot slug and step order, tidy
…ain feedback, preview picks an order with a product grid or shows sample products, seed cross-sells
…never the order's own, the order with the most grids, every sample grid named, one order load each, Check again safe after leaving the page
… reveal moves only the axis that needs it
…e build, translator comments kept in the minified build, steady list title row, schedule names plan 032
…r, so make-pot has no placeholder warning; pot rebuilt
…tion (public at submission, Pro included, default branch develop)
…elease skips lint (YAYMATIK_SKIP_LINT=1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR gets YayMatik ready to submit to WordPress.org:
%ifor table names, product lists are bounded, the Tailwind reset no longer reaches WordPress's menu and bar.Base:
develop5000114. No schema change. One commit per checkpoint, plusfix:commits from review. Built in three runs: CP0–CP7, CP8a–CP9, CP10–CP12.Checkpoints
@internalonStep,ModuleandDataItem..claude/docs/context-wporg-release-checklist.mdand/wp-review.--wp-env-minsite (dev/wp-env-min/).check-*takes local,--wp-envor--wp-env-minand refuses staging../run.sh check-allprints one PASS/FAIL/SKIP table../run.sh probe-mysql --stagingmakes read-only MySQL 8 checks: eraseREGEXP,GET_LOCK, the user meta key collation.ThemeProviderandThemeToggleare gone;<html>is alwaysyay-light.CreateWorkflowButton(inshared/create/) is in the header on Overview and the editor. The editor saves before it creates, so a failed save leaves no new workflow behind.Requirements::met()runs onplugins_loaded, before the autoloader. On failure: one notice on the Plugins screen, nothing else loads.uninstall.php→Uninstalleralways removes jobs and transients. Tables, options and meta go only withYAYMATIK_REMOVE_ALL_DATA; coupons stay. Each site of a network is cleaned.I18n.phpremoved.YayMatikMenuAdapter; portablesed -i.bak.data:URIs.:where(#yaymatik, body > :not(#wpwrap)).check-settings: ranges, all-or-nothing save, one 400 per field, each Health check fix. The site keeps its daily job times.readme.txt; the ordered release gate inops-release.md.src/License, as YayBulkOrder's approved lite build does.dev/scripts/lib/free-admin-shell.phpthen addsclass_existsguards to the scoped copy, and ABSPATH guards to every admin-shell file in both editions.composer.jsonships, the unusedYayMatikProLicenseAdapteris deleted,react/jsx-runtimeis external, exception messages are escaped, the ABSPATH guard is in 5 more files, andAdminShell::boot()runs once.%i(3b6d48f, fix a1a6f11)%i.INlists useSchema::in(), which returns''for an empty list so the query fails loudly.--wp-env-min: activation printed nothing, and every screen plus one order through a workflow left nodebug.log.pnpm makepot;languages/yaymatik.pot, also rebuilt into each release zip. Roadmap statuses.has_cross_sells/has_upsellsfields keep the order's real value.pnpm lint:phpfirst and stops on an error.wp i18n make-poton the zip prints no warnings.%discount_type%/%expiry_days%as unordered%d/%e. The card text is unchanged../run.sh deploylints PHP in the checkout, then builds in its clean worktree with the lint skipped (YAYMATIK_SKIP_LINT=1): the worktree has no lint tools../run.sh releasestill lints and stops when the tools are missing.Tests
pnpm lint,pnpm test(Vitest),pnpm lint:php,pnpm test:php(PHPUnit),pnpm build../run.sh check-all --wp-envand--wp-env-min: storage, runs, late module, carts, lifecycle, win-back, catalog, settings, plugin lifecycle../run.sh probe-mysql --staging.pnpm e2e, three runs in a row./wp-reviewon the free zip (Plugin Check included).WordPress.org review notes
Short answers for the review thread (U3):
includes/Workflow/Core/Cart/EmailCapture.php,wc_ajax_yaymatik_capture_email)Sec-Fetch-Site,Origin,Refereragainst the store's own URL;RequestOrigin), sanitizes its two fields and rate-limits by session, IP and site.{"success":true}, so it never says whether an address is known.yaymatik_modules,yaymatik_resendable_emailsandyaymatik_change_role_allow_allare prefixed. Plugin Check flags them only because they are passed as class constants (self::HOOK,self::FILTER,self::ALLOW_ALL_FILTER).woocommerce_add_to_cart_validation(includes/Engine/FEPages/RestoreCart.php) is WooCommerce's own filter. The restore-cart link applies it before it adds each saved line, exactly as WooCommerce's add-to-cart form does, so other plugins can refuse a product.vendor-prefixed/)src/License).class_existscheck to each (dev/scripts/lib/free-admin-shell.php, in the public repo), so the free plugin never loads license code and never fails when another YayCommerce plugin is installed.defined( 'ABSPATH' ) || exit;to each of its files.UnescapedDBParameter/InterpolatedNotPreparedwarnings (28)RunStore,CartStore,RunStepStore,TriggerClaimStore,WorkflowStoreandCustomerStats.$wpdb->prepare()where it runs. Table and column names are%i; values are%d/%s.Schema::in()makes the%d,%d,…list for anIN (…), one placeholder per value passed.$filterand$aboutare fixedWHEREparts with placeholders for the values passed with them.$busy,$columnsand$setare lists of placeholders or fixed column names.readme.txt. React, ReactDOM and the JSX runtime are not bundled: the app uses WordPress's ownreact,react-domandreact-jsx-runtimescripts.Open before submission
YayCommerce/YayAutomation, goes public (Pro modules included); its default branchdevelopholds the zip's code (B1).