Skip to content

[upstream] [BUGFIX] Preserve form finisher select values - #83

Draft
github-actions[bot] wants to merge 1 commit into
release/v14from
upstream-sync/e61cdcf666
Draft

github-actions[bot] wants to merge 1 commit into
release/v14from
upstream-sync/e61cdcf666

Conversation

@github-actions

Copy link
Copy Markdown

Automatisch vorgeschlagener Cherry-pick aus TYPO3-CMS/form @ 14.3.

⚠ Conflict detected — diese PR enthält Konfliktmarker und ist als Draft markiert.
Bitte lokal auschecken, manuell auflösen, dann das Label needs-conflict-resolution entfernen und die PR aus dem Draft-Status nehmen.

Upstream-Commit

Commit-Message

Upstream-Commit-Message anzeigen
[BUGFIX] Preserve form finisher select values

Form finisher options provide FormEngine configuration for rendering
fields inside FlexForm overrides. This configuration was passed through
`TranslationService::translateValuesRecursive()` as a whole. The form
editor translated its definitions the same way.

As a result, not only labels but also technical configuration values
were translated. The item value "default" of the `translation.language`
option of email finishers was stored as its backend label, for example
"Default" or "Standard", in form plugins and in form definitions. Such
a value matches no configured item and forces emails into the default
language.

Restrict translation of FlexForm overrides to textual FormEngine
properties: labels, descriptions, placeholders, section titles, labels
of item groups and labels of legacy numeric select items. The form
editor keeps the values of select options untranslated.

An upgrade wizard replaces every non-empty value of the option that is
not a valid language key by "default" in form plugins and in form
definitions stored in the database. An Important changelog entry
documents the new translation behavior and the migration.

Resolves: #87675
Releases: main, 14.3
Change-Id: Ia50e819a0b710c9bd7637ad7c992205cc94c4d08
Signed-off-by: Oli Bartsch <bo@cedev.de>
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/97580
Tested-by: core-ci <typo3@b13.com>


Erzeugt von .github/workflows/upstream-sync.yml.
Um diesen Commit künftig nicht erneut vorzuschlagen, schließe die PR ohne Merge — der Marker unten bleibt erhalten.

Form finisher options provide FormEngine configuration for rendering
fields inside FlexForm overrides. This configuration was passed through
`TranslationService::translateValuesRecursive()` as a whole. The form
editor translated its definitions the same way.

As a result, not only labels but also technical configuration values
were translated. The item value "default" of the `translation.language`
option of email finishers was stored as its backend label, for example
"Default" or "Standard", in form plugins and in form definitions. Such
a value matches no configured item and forces emails into the default
language.

Restrict translation of FlexForm overrides to textual FormEngine
properties: labels, descriptions, placeholders, section titles, labels
of item groups and labels of legacy numeric select items. The form
editor keeps the values of select options untranslated.

An upgrade wizard replaces every non-empty value of the option that is
not a valid language key by "default" in form plugins and in form
definitions stored in the database. An Important changelog entry
documents the new translation behavior and the migration.

Resolves: #87675
Releases: main, 14.3
Change-Id: Ia50e819a0b710c9bd7637ad7c992205cc94c4d08
Signed-off-by: Oli Bartsch <bo@cedev.de>
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/97580
Tested-by: core-ci <typo3@b13.com>

(cherry picked from commit e61cdcf6666728d902e7aa8212f1559afd1a1ced)

[CONFLICT — manual resolution required]
@github-actions github-actions Bot added upstream-sync Automatically proposed cherry-pick from upstream needs-conflict-resolution Cherry-pick had conflicts, manual resolution required bugfix Bugfix from upstream labels Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bugfix from upstream needs-conflict-resolution Cherry-pick had conflicts, manual resolution required upstream-sync Automatically proposed cherry-pick from upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant