Repository navigation
[upstream] [BUGFIX] Preserve form finisher select values - #83
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Form finisher options provide FormEngine configuration for rendering fields inside FlexForm overrides. This configuration was passed through `TranslationService::translateValuesRecursive()` as a whole. The form editor translated its definitions the same way. As a result, not only labels but also technical configuration values were translated. The item value "default" of the `translation.language` option of email finishers was stored as its backend label, for example "Default" or "Standard", in form plugins and in form definitions. Such a value matches no configured item and forces emails into the default language. Restrict translation of FlexForm overrides to textual FormEngine properties: labels, descriptions, placeholders, section titles, labels of item groups and labels of legacy numeric select items. The form editor keeps the values of select options untranslated. An upgrade wizard replaces every non-empty value of the option that is not a valid language key by "default" in form plugins and in form definitions stored in the database. An Important changelog entry documents the new translation behavior and the migration. Resolves: #87675 Releases: main, 14.3 Change-Id: Ia50e819a0b710c9bd7637ad7c992205cc94c4d08 Signed-off-by: Oli Bartsch <bo@cedev.de> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/97580 Tested-by: core-ci <typo3@b13.com> (cherry picked from commit e61cdcf6666728d902e7aa8212f1559afd1a1ced) [CONFLICT — manual resolution required]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatisch vorgeschlagener Cherry-pick aus TYPO3-CMS/form @ 14.3.
Upstream-Commit
e61cdcf6666728d902e7aa8212f1559afd1a1cedCommit-Message
Upstream-Commit-Message anzeigen
Erzeugt von
.github/workflows/upstream-sync.yml.Um diesen Commit künftig nicht erneut vorzuschlagen, schließe die PR ohne Merge — der Marker unten bleibt erhalten.