Repository navigation
[upstream] [BUGFIX] Reject invalid form page index gracefully - #78
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
The internal "__currentPage" argument of ext:form was cast to int without any validation. Manipulated values like "-1 OR 5*5=25 -- ", as sent by bots, resulted in a FormException about a non-existing page, which got logged with alert severity for every request. The value is now validated to be a non-negative integer. Otherwise a BadRequestException is thrown, rendering the usual error message in the frontend. Its exception code is registered as ignored code in the exception handlers, the same way as for failed HMAC validations, to avoid flooding the log with forged requests. Resolves: #111026 Releases: main, 14.3 Signed-off-by: Nikita Hovratov <nikita.h@live.de> Change-Id: I273ecab2fb8fcbc236ebb5947b73798af1667056 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/97559 Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: core-ci <typo3@b13.com> (cherry picked from commit 533484b037a42d783e52d33e7265923814346b62) [CONFLICT — manual resolution required]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatisch vorgeschlagener Cherry-pick aus TYPO3-CMS/form @ 14.3.
Upstream-Commit
533484b037a42d783e52d33e7265923814346b62Commit-Message
Upstream-Commit-Message anzeigen
Erzeugt von
.github/workflows/upstream-sync.yml.Um diesen Commit künftig nicht erneut vorzuschlagen, schließe die PR ohne Merge — der Marker unten bleibt erhalten.