[zcsahok]

In the previous PR #540, I missed that trailing newline characters aren't stripped from the argument. As a result, the MIN suffix isn't removed correctly, causing a parsing error.

First adding trailing NL to test_minitest_10min to reproduce the issue.

[zcsahok]

The fix: trimming value before parsing.

[dl1jbe]

Fine. Merging it in.

[dl1jbe]

So test failed. Will check and fix tomorrow.

[zcsahok]

There is a ongoing migration to Ubuntu 26 and this failed job ran on it. In my repo it was today still Ubuntu 24 and it was OK. There must be some change to astyle in 26.

[dl1jbe]

Yes, newer astyle versions differs in indentation of some code snippets.
Just tested with version 3.6.7 and 3.6.18
3.6.7 wants changes in src/parse_logcfg.c
3.6.18 instead wants to change cabrillo_utils.c, plugins.c, getexchange.c

[dl1jbe]

Astyle gets fooled when more than one struct member gets assigned per line.

int rc = cfg_string((cfg_arg_t) {
    .char_p = my.call, .size = sizeof(my.call),
    .strip = true, .string_type = STATIC
});

gets converted into

int rc = cfg_string((cfg_arg_t) {
    .char_p = my.call, .size = sizeof(my.call),
                       .strip = true, .string_type = STATIC
});

So either wrap by INDENT-OFF INDENT-ON or have .char_p and .size assignment on two separate lines.

Btw, the problem seems to be fixed in newer astyle versions.

[zcsahok]

OK, I see. It looks like only two places in parse_logcfg.c are affected. I’ll submit a PR to fix them.