Repository navigation
test: exempt the unmigrated Teradata graph templates from binding checks - #81
Merged
Merged
Conversation
The graph-lineage and catalogue-interface templates were written for the old flat context and are kept unchanged until the port-or-retire decision (modules/observability/README.md). No phase renders them and they still use the old placeholder styles, so the dead-template and Jinja-only checks failed and turned validate red on main. Exempt them through one named UNMIGRATED list. Remove the entries when the templates are ported or retired. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
NathanG-TD
added a commit
that referenced
this pull request
Oct 22, 2026
Run locally against the Teradata test system: 60 passed, none failed or skipped. It clears the two package failures #81 fixed and records, for the first time on Teradata, the rendering and engine tests of the 2.0.0 metadata contract (#76) and the README-section package test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a named
UNMIGRATEDlist totooling/validation/tests/test_binding_package.py. Two checks skip the templates on it:test_every_template_is_declared_or_caller_renderedtest_templates_use_only_jinja_substitution_and_no_product_literalsThe list covers
modules/observability/05-to10-andpatterns/catalogue-interface/for the Teradata binding.Why
validatehas failed onmainsince the #77 merge (run 38559143162) and so fails on every open PR, including #76. The cause is that the graph-lineage and catalogue-interface templates are deliberately unmigrated.modules/observability/README.md("Graph-lineage facet: not migrated") andPLATFORM_PROFILE.mdsay no phase renders them and that they are kept unchanged until the port-or-retire decision. The tests that hold the binding to the Jinja rules do not know this, so they report:07-graph-acl-views.sql.j2"is rendered by nothing".{name}format placeholder in08-catalogue-seed.sql.j2, and colon-named parameters incatalogue-interface/02-lifecycle-dml.sql.j2.The change makes the exemption explicit and in one place. It does not change any template and does not port anything. Delete the entries when the templates are ported or retired, and the checks cover them again.
How to Test
python -m unittest discover -s tooling/validation/tests.OK(verified locally).validateis green on this PR.Checklist
UNMIGRATEDpoints at the README)🤖 Generated with Claude Code