Repository navigation
Seagate: Fix helium pressure trip issue in smartctl - #8
Open
sharma-nidhi wants to merge 1 commit into
Open
sharma-nidhi wants to merge 1 commit into
sharma-nidhi wants to merge 1 commit into
Conversation
Signed-off-by: nidhi-sharma <nidhi.sharma@seagate.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how the "Helium Pressure Threshold Tripped" value is extracted and displayed in both ATA and SCSI farm log outputs. The main change is to decode the field according to its format, ensuring that the reported value is accurate and consistent in both human-readable and JSON outputs.
Reliability statistics decoding improvements:
ataPrintFarmLogandscsiPrintFarmLog(insrc/farmprint.cpp), theheliumPresureTripfield is now decoded to extract the correct value based on its format, instead of displaying the raw value. This ensures more accurate reporting of the "Helium Pressure Threshold Tripped" status. [1] [2]JSON output consistency:
jref5["helium_presure_trip"]) and SCSI (jref5["helium_pressure_threshold_tripped"]) logs now use the decodedheliumPressureTrippedvalue instead of the raw field, ensuring consistency between the human-readable and JSON representations. [1] [2]