Repository navigation
axolotl-launcher@1.10.5: update repository URLs after upstream move - #1835
xinvxueyuan wants to merge 6 commits into
Conversation
Axolotl moved from Mystic-Stars/Axolotl to the Axolotl-Launcher organization. The v1.9.9 portable archive hash is unchanged after the move, so only the repository addresses (url, checkver.github, autoupdate) are updated. Closes ScoopInstaller#1834
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
 |
| Layer / File(s) | Summary |
|---|---|
Repository references and hash autoupdate bucket/axolotl-launcher.json |
The 64-bit download URL, version-check repository, and autoupdate URL now reference Axolotl-Launcher/Axolotl. Hash autoupdate reads $.artifacts.portable.sha256 from latest.json. |
Possibly related PRs
- ScoopInstaller/Games#1837: Adds a beta manifest that uses the Axolotl-Launcher/Axolotl repository for release assets and version checks.
Severity of issue fixed: Low
Merge Risk: 
27cc8
-
Future updates may fail checksum validation because the manifest cannot derive the portable archive hash from the release metadata.
Pre-merge checks: 
-
Check name Status Explanation Resolution Linked Issues check Issue #1834requires the artifact hash to remain66f8acac2c903b63f5e74e2a434e658705350baa905bd163fe07d675def65e92because the repository move does not change the artifact. The current manifest uses …Restore the issue-required artifact hash and remove the unrelated hash-source change. Keep the repository migration in the download URL, checkver.github, and URL autoupdate.Out of Scope Changes check The repository-reference changes are in scope for #1834. The current pull request also changes the pinned artifact hash and addsautoupdate.hashusinglatest.json. Issue#1834explicitly states th…Limit the manifest change to the repository references required by #1834. Revert the hash value and the added hash autoupdate unless a separate issue defines that release-update work.-
Check name Status Explanation Title check The title clearly identifies the manifest, version, and main change: updating repository URLs after the upstream move. Description check The description provides a clear overview, lists the changed fields, explains why the update is needed, references issue #1834, confirms the contributing guide review, and documents validation results…Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Full details: Description check
-
Explanation
The description provides a clear overview, lists the changed fields, explains why the update is needed, references issue
#1834, confirms the contributing guide review, and documents validation results.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Full details: Linked Issues check
-
Explanation
Issue
#1834requires the artifact hash to remain66f8acac2c903b63f5e74e2a434e658705350baa905bd163fe07d675def65e92because the repository move does not change the artifact. The current manifest uses9446967449cbf8f5942b037131e96785a85bd974fd5feddf6bea2200ed876e48and adds alatest.jsonhash source. The current manifest does useAxolotl-Launcher/Axolotlin the download URL,checkver.github, and URL autoupdate.Resolution
Restore the issue-required artifact hash and remove the unrelated hash-source change. Keep the repository migration in the download URL,
checkver.github, and URL autoupdate.
Full details: Out of Scope Changes check
-
Explanation
The repository-reference changes are in scope for
#1834. The current pull request also changes the pinned artifact hash and addsautoupdate.hashusinglatest.json. Issue#1834explicitly states that the artifact and hash remain unchanged. These additional changes are not required for the repository migration.Resolution
Limit the manifest change to the repository references required by
#1834. Revert the hash value and the added hash autoupdate unless a separate issue defines that release-update work.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
8c5eba86-5590-47e7-9d54-1456c8f3d69b
📒 Files selected for processing: 1
bucket/axolotl-launcher.json
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
The previous commit rebuilt the file from scratch, which dropped the escaped quotes and backslashes in pre_install and made the manifest unparseable. Rebuild from the upstream original and only rewrite the repository addresses, so pre_install keeps its original " and \\ escaping.
xinvxueyuan
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. axolotl-launcher
|
xinvxueyuan
changed the title
The merge of master into this branch took master's hash while keeping this branch's 1.10.5 url, leaving a 1.9.9 digest next to a 1.10.5 artifact. Restore the published SHA-256 of the 1.10.5 portable zip, which master already had and which GitHub Release asset.digest, update.axlmc.org/api/downloads/latest?channel=release and the website release metadata all report as 94469674. Verified: checkver/checkurls/checkhashes OK, Pester 428/428, and `checkver -Update -ForceUpdate` reproduces this hash from the GitHub release digest.
Release metadata now publishes the portable zip digest, so Excavator no longer has to download the archive to hash it. The jsonpath picks artifacts.portable.sha256 out of the tagged latest.json, which is the same value this manifest already carries. Scoop falls back to downloading and hashing when the path yields nothing, so releases predating the artifacts field still update.
…etadata" This reverts commit 27cc8b0.
Overview
axolotl-launcherat the project's current home,Axolotl-Launcher/Axolotl, after the repository moved out of theMystic-Starsaccount.architecture.64bit.url,checkver.githubandautoupdate. Thehashis unchanged, because the move does not change the artifact.GET https://api.github.com/repos/Mystic-Stars/Axolotlalready reports"full_name": "Axolotl-Launcher/Axolotl", and the redirect stops working if that name is ever reused.Testing
bin/formatjson.ps1: no changes in content (output is byte-identical once CRLF is normalised, as required by.gitattributes).bin/checkver.ps1 axolotl-launcher -ThrowError→axolotl-launcher: 1.9.9bin/checkver.ps1 axolotl-launcher -Update→ resolves1.9.9and leaves the manifest unchanged, i.e.autoupdatereproduces the current URL.bin/checkurls.ps1 axolotl-launcher→ OK. One run out of several failed with a transient local TLS error; the same URL downloaded fine incheckhashes.bin/checkhashes.ps1 axolotl-launcher→axolotl-launcher: OKCloses #1834