Repository navigation
pkcs1v15: use ctutils::CtGt to address TODO - #726
Merged
Merged
Conversation
tarcieri
commented
Oct 19, 2026
| let valid_ps = Choice::from_u8_lsb((((2i32 + 8i32 - index as i32 - 1i32) >> 31) & 1) as u8); | ||
| // PS starts at offset 2 and must contain at least 8 nonzero octets, | ||
| // so the first zero separator must occur at offset 10 or later. | ||
| let valid_ps = index.ct_gt(&9); |
Member
Author
There was a problem hiding this comment.
This unfortunately doesn't exist but would be a clearer way to write it:
Suggested change
| let valid_ps = index.ct_gt(&9); | |
| let valid_ps = index.ct_ge(&10); |
Thought about leaving a comment to that effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.