Skip to content

🐛 Limit Aegis loading indicators to selected fields - #889

Merged
superbuggy merged 1 commit into
mainfrom
fix/blinking-field
Oct 27, 2026
Merged

superbuggy merged 1 commit into
mainfrom
fix/blinking-field

Conversation

@superbuggy

@superbuggy superbuggy commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

AEGIS-542 Limit Aegis loading indicators to selected fields

Checklist:

  • Commits consolidated
  • Changelog updated
  • Test cases added/updated
  • Integration tests updated

Summary:

Show loading indicators only for the fields selected in Aegis Multi Suggest. Selecting CWE ID and Mitigation now animates only those fields, accurately reflecting which values are being generated.

Changes:

  • Capture enabled, selected fields when a multi-suggestion request starts and use that snapshot for per-field loading indicators.
  • Clear the loading selection after success or failure while retaining the shared busy state that prevents overlapping suggestion requests.
  • Add regression coverage for CWE ID + Mitigation, individual fields sharing backend features, unchanged unselected values, request failures, and subsequent selections.
  • Document the fix under Unreleased in the changelog.

Considerations:

  • Only selected fields receive generated values, including when a backend feature returns results for multiple fields.
  • Verification passed: 62 tests across the coordinator and Multi Suggest component suites, full project type checking, ESLint on changed TypeScript files, and git diff --check.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9497c9db-8c0d-4355-a571-a2934919cf70
Commits

Reviewing files that changed from the base of the PR and between 2cb5990 and 4cfdf7c.

Files selected for processing: 2
  • CHANGELOG.md
  • src/composables/aegis/__tests__/useFullFlawSuggestions.spec.ts
Files skipped from review as they are similar to previous changes: 1
  • CHANGELOG.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • During bulk suggestion generation, loading indicators now appear only for fields selected for generation; unselected fields remain idle. Indicators clear when generation completes, and results continue to apply only to selected fields. This makes it easier to see which fields are being processed without suggesting that other fields are receiving updates.

The bulk suggestion coordinator now tracks fields included in a request. Loading indicators appear only for enabled fields in that set and clear when the request finishes. The test checks loading state while a request is pending and after it resolves.

Changes: Aegis bulk suggestions

Layer / File(s) Summary
Track requested fields and loading state
src/composables/aegis/useFullFlawSuggestions.ts, src/composables/aegis/__tests__/useFullFlawSuggestions.spec.ts, CHANGELOG.md
The coordinator records requested fields and clears them when the request finishes. Field loading state checks whether each enabled field is in the set. The test checks loading state before and after the request resolves. The changelog records the loading-indicator change.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: c-valen

Merge Risk: Minimal · up to 4cfdf

No actionable merge-blocking risk remains identified for this change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: limiting Aegis loading indicators to selected fields.
Description check Passed The description follows the repository template and includes the issue ID, checklist, summary, detailed changes, considerations, testing, and changelog information. It clearly records that integration…
Docstring Coverage Passed Docstring coverage is inconclusive: files from earlier reviews still need to be rechecked within the check's analysis limits. Not blocking.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description follows the repository template and includes the issue ID, checklist, summary, detailed changes, considerations, testing, and changelog information. It clearly records that integration tests were not updated.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@superbuggy
superbuggy requested a review from C-Valen October 26, 2026 16:15
Comment thread CHANGELOG.md Outdated
# OSIM Changelog
## [Unreleased]
### Fixed
* Show Aegis Multi Suggest loading indicators only for fields selected for generation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a ticket for this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this tests update feels a bit of an overkill for a minimal UI bug fix.

The per-field loading check looks as the useful part. The two new tests mostly repeat blocking, apply, and flag behavior this file already covers.

@superbuggy superbuggy self-assigned this Oct 27, 2026
@superbuggy
superbuggy merged commit 09a19c0 into main Oct 27, 2026
6 checks passed
@superbuggy
superbuggy deleted the fix/blinking-field branch October 27, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants