Skip to content

fix: remove 'keep-project' as its not provided on all levels of process-compose #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srid merged 4 commits into from
Oct 14, 2026
Merged

fix: remove 'keep-project' as its not provided on all levels of process-compose #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
959f58f
fix: remove keep-project option
Oct 7, 2026
550ce8e
fix: add changelog
Oct 13, 2026
35c71dc
fix: review changes
Oct 14, 2026
62fe8e5
fix: review changes
Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
- #22: `command` option is no longer wrapped in `writeShellApplication`.
- #20: Fix definiton of `probe.exec`
- #53: Make process submodule a proper submodule (allowing use of `imports` etc)
- Breaking changes
- #113: Remove `keep-project` as its not provided on all level of `process-compose` CLI.


## 0.1.0 (Jun 12, 2023)
Expand Down
6 changes: 0 additions & 6 deletions nix/process-compose/cli.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,6 @@ in
default = { };
type = types.submodule {
options = {
keep-project = mkOption {
type = types.bool;
default = false;
description = "Pass --keep-project to process-compose";
};
log-file = mkOption {
type = types.nullOr types.str;
default = null;
Expand Down Expand Up @@ -159,7 +154,6 @@ in
description = "The final CLI arguments we will pass to process-compose binary.";
default = let o = config.cli.options; in lib.escapeShellArgs (
(lib.optionals (o.log-file != null) [ "--log-file" o.log-file ])
++ (lib.optionals o.keep-project [ "--keep-project" ])
++ (lib.optionals o.no-server [ "--no-server" ])
++ (lib.optionals o.ordered-shutdown [ "--ordered-shutdown" ])
++ (lib.optionals (o.port != null) [ "--port" "${builtins.toString o.port}" ])
Expand Down
Loading