Repository navigation
Allowing inlining of quantum functions - #3420
Merged
Merged
Conversation
maliasadi
approved these changes
Oct 30, 2026
maliasadi
left a comment
maliasadi
left a comment
Member
There was a problem hiding this comment.
Looks good! Just update the changelog before merging the PR 🙌
albi3ro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Performed by Cursor.
Right now, gradients don't work with decomposed operators, because gradients can't handle function calls with both quantum and classical instructions inside them.
As an easier fix for this, I thought we could just inline the function calls for now.
But we added something so that functions with quantum instructions can only be inlined if they have a target attribute. This branch is just getting rid of that restriction and seeing what the consequences are.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: