Repository navigation
[WIP] fix: preserve nested operator parameters and wires during decomposition - #3416
Open
andrijapau wants to merge 23 commits into
Open
andrijapau wants to merge 23 commits into
andrijapau wants to merge 23 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3416 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 177 177
Lines 21699 21725 +26
Branches 2162 2167 +5
=======================================
+ Hits 20886 20912 +26
Misses 629 629
Partials 184 184 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Generated with the support of Codex, still reviewing myself.
Context:
Catalyst can retain an abstract nested operator when lowering decomposition rules instead of reconstructing it from the actual operands. For GQSP, this leaves symbolic wire placeholders in the generated IR and blocks binary compilation.
Description of the Change:
Reconstruct hybrid arguments from their parameter and wire operands before invoking decomposition rules, preserving the compiler’s operand ordering.
Benefits:
Enables GQSP binary compilation with the correct nested operator parameters and wires. Regression tests cover parameterized and multiwire operators and compare compiled results against reference execution.
Possible Drawbacks:
Adds reconstruction logic for hybrid arguments that must remain consistent with the operator lowering’s operand layout.
[sc-135523]