Repository navigation
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cal-Adapt WRF ingestion currently lives in draft #3967 as a downloader that also extracts, converts units, and writes CF files, with a source-specific bypass in
met.process(). This replacement keeps download and CF conversion separate and uses the normal site-level dispatch.download.CalAdaptWRF()stages native Zarr chunks throughcaladaptaer::cae_stage_zarr()and writes annual JSON manifests. It does not convert weather values.met2CF.CalAdaptWRF()reads the manifests and delegates extraction, conversion, provenance, and validated output reuse tocae_build_met_drivers(). It publishes annual files with PEcAn prefixes that retain model, scenario, and resolution.met.process().The source defaults to CESM2 / ssp370 / d03. d01 and d02 remain selectable. Source calendars and missing values are preserved. The JSON manifests reference local cache paths, so keep the cache until conversion finishes. Shared-cache downloads should run serially; this PR does not add cache locking.
Dependency / merge order: keep this PR in draft until the caladaptaer stack #25–30 lands. The adapter requires the runtime APIs in #25–28; it was tested against stack head
f5d50dacb71fbe88052f7b30b7b3b39ba29b85cf. Dependencies point to the normal upstream repository, assuming those changes have merged, rather than pinning a temporary stack branch. The functions fail explicitly when the source-staging API is absent. Remote Zarr access requires R-linked GDAL >=3.9.Validation:
git diff --checkpassed.R CMD check --no-manual --no-vignettes --no-tests --no-examplescompleted with no errors, 4 warnings and 3 notes. Reports concern unchanged datasets/compression, unbuilt vignettes, the license stub, existing global bindings, and a local PROJ diagnostic. The focused tests above were run separately; the full package test suite and live downloads were not run.This PR does not fix SIPNET's assumption of complete Gregorian years or connect the direct-file UCLA reanalysis APIs. The documentation identifies the downstream calendar limitation.
Supersedes #3967; retains credit for Akash B V's original contribution.