Repository navigation
fix(deps): drop manifest-redundant httpx pin, bump caldav to 3.3.0a1 - #51
Merged
Merged
Conversation
hassfest now rejects the manifest's httpx>=0.28.0 requirement outright -- HA core already bundles httpx, so a custom integration must not redeclare it (the import itself is unaffected; HA guarantees httpx is importable). caldav==2.1.0 also conflicts with HA core's own caldav==3.3.0a1 pin. Verified compatibility rather than assuming it: pip-installed the real caldav==3.3.0a1 into .venv (dropping the now-nonexistent [async] extra) and ran the full suite -- all 130 caldav-specific tests plus the rest of the suite pass unchanged (same pre-existing 6 network-blocked test_sign_retrieval.py failures as every other run in this sandbox). ruff and mypy (run per-path as CI does) are both clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVTaYxJNE3ANndgwg7LJPt
HA core's own caldav pin moved from ==3.3.0a1 to ==3.5.0a0 within minutes of the previous commit -- it's tracking caldav's prerelease line and isn't stable. An exact pin here means hassfest goes red again on the next upstream bump with no code change on our side to explain it. Switched to caldav>=3.3.0a1, a floor hassfest's compatibility check can satisfy against any forward move of HA's own pin. Re-verified against the real caldav==3.7.0 (current stable latest, most likely to actually get resolved) in addition to 3.3.0a1: all 130 caldav tests and the full suite pass unchanged on both. Bumped the pyproject.toml dev pin to the stable 3.7.0 so local dev/test installs track a real release, not an abandoned alpha. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVTaYxJNE3ANndgwg7LJPt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the `hassfest` CI check (`Validate manifest.json`), which started failing on every PR — not just PR #49, see its comment thread — because:
Didn't assume compatibility — verified it: pip-installed the real `caldav==3.3.0a1` into `.venv` and ran the suite before writing this up.
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01NVTaYxJNE3ANndgwg7LJPt