Repository navigation
chore: remove stale # lgtm suppression comments from pipeline.py overloads - #29
Merged
Merged
Conversation
…loads The commit that closed the code-scanning alerts (#27) claimed these were already removed, but they weren't -- both copies still had them. GitHub's CodeQL Action does not honor inline `# lgtm[...]` comments (that's an LGTM.com-only mechanism), so they were dead weight that looked like a suppression but did nothing. The underlying py/ineffectual-statement alerts (4, on the `...` stub bodies mandated by typing.overload/PEP 484) were dismissed via the GitHub API as false positives instead, which is the actual mechanism GitHub's CodeQL Action respects. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py/ineffectual-statement, on the@overload...stub bodies inpipeline.pyand its vendored copy) are dismissed via the GitHub API as false positives — PEP 484 mandates that syntax, it's not an actual no-op bug.# lgtm[py/ineffectual-statement]comments that were sitting next to them. GitHub's CodeQL Action doesn't honor# lgtm(that's an LGTM.com-only convention), so they were dead/misleading — a prior commit claimed to have removed these already but hadn't.Test plan
gh api .../code-scanning/alertsthat all 4 alerts are nowdismissed