[Pascal-ZeGerman]

Summary

• GPS stale watchdog + pipeline health binary sensor (260601-feq-01/02)
• 3 silent-failure fixes in suspension handling found in code review
• Fix ASP suspension calendar fetch: switch to a browser User-Agent so NYC DOT's ICS endpoint stops returning 403 (was silently falling back to a stale, incorrect date list — e.g. missing 2026-07-03 Independence Day observance), and regenerate the fallback list from the real 36-entry authoritative calendar

Test plan

• pytest tests/test_suspension.py tests/test_ha_integration.py — 111 passed
• Verified live against NYC DOT ICS: fetch now returns 200 (previously 403)
• Verified is_suspended(2026-07-03) returns True ("Independence Day") on the reloaded integration in the running Home Assistant container
• Verified a normal non-suspended Friday (2026-07-10) still correctly returns not-suspended

🤖 Generated with Claude Code

[Pascal-ZeGerman]

Code review

Found 4 issues:

1. Suspension fallback retains stale holiday-sourced suspension. The comment on line 2163 says this retains "an active 311 suspension" through transient API errors, but the guard checks only is_suspended, not source. If the previous day was a holiday (source="holiday") and today is not, a 311 API failure causes the stale holiday suspension to carry over — telling users ASP is suspended on an enforced day. Fix: gate on self.data.suspension_state.source in ("ha_nyc311", "emergency").

GPS2ASP-Resolver/custom_components/asp_parking/coordinator.py

Lines 2163 to 2189 in efcd067

	)
	info = fallback_info
	except Exception: # noqa: BLE001
	logger.warning(
	"311 suspension poll failed, failing open", exc_info=True
	)
	info = fallback_info
	self._async_apply_suspension_state(info)
	self._async_notify_entities()
	async def _async_maybe_send_notification(self, schedule: ScheduleResult) -> None:
	"""Send push notification if next ASP window is within self._notify_lead_time minutes.
	Guards:
	- CONF_NOTIFY_SERVICE must be configured (D-15)
	- Notification suppressed when debug_enabled AND suppress_notifications (D-15)
	- Only fires once per unique CleaningWindow (D-14)
	"""
	if not self._notify_service:
	return
	if self._debug_enabled and self._debug_suppress_notifications:
	return
	if not isinstance(schedule, ScheduleFound):
	return
	if schedule.next_window is None:
	return

2. Setup retry counter not cleared on entry unload. _SETUP_RETRY_COUNT_KEY_TPL is incremented on each ConfigEntryNotReady (line 219) and cleared only on successful setup (line 233), but async_unload_entry never pops it. If a user disables the integration while the counter is at 3, re-enables it, and hits 2 more failures, the Repair issue fires after only 2 retries in the new lifecycle — not 5. Fix: add hass.data.pop(_SETUP_RETRY_COUNT_KEY_TPL.format(entry_id=entry.entry_id), None) in async_unload_entry.

GPS2ASP-Resolver/custom_components/asp_parking/__init__.py

Lines 306 to 322 in efcd067

	Stops the coordinator and unloads entity platforms.
	Args:
	hass: Home Assistant instance.
	entry: Config entry being unloaded.
	Returns:
	True if unload was successful.
	"""
	# Stop the coordinator (cancels listeners, debouncer)
	await entry.runtime_data.async_stop()
	# Unload entity platforms
	return await hass.config_entries.async_unload_platforms(entry, PLATFORMS)
	async def async_remove_entry(hass: HomeAssistant, entry: ConfigEntry) -> None:

3. GPS stale notification unconditionally dismissed on startup. async_start() (line 468) calls _gps_watchdog_rearm(), which always calls pn_dismiss (line 1621) with no check on current GPS age. If GPS was legitimately stale before an HA restart, the existing "GPS Signal Lost" notification is silently cleared and the user must wait another full stale_timeout hours (default: 8h) for it to reappear. Fix: skip the dismiss in _gps_watchdog_rearm when called from startup, or check whether data.last_gps_update already exceeds the timeout before dismissing.

GPS2ASP-Resolver/custom_components/asp_parking/coordinator.py

Lines 1607 to 1622 in efcd067

	``asp_parking_gps_stale`` persistent notification and triggers an entity
	state refresh via ``_async_notify_entities()``.
	"""
	self._gps_watchdog_cancel()
	from homeassistant.components.persistent_notification import (
	async_dismiss as pn_dismiss,
	)
	pn_dismiss(self.hass, "asp_parking_gps_stale")
	delay = float(self.stale_timeout * 3600)
	@callback
	def _on_gps_stale(_now: datetime) -> None:
	from homeassistant.components.persistent_notification import (
	async_create as pn_create,

4. Lazy persistent_notification imports inside @callback methods. _gps_watchdog_rearm (sync @callback, line 1607) and its nested _on_gps_stale (@callback, line 1625) both do inline from homeassistant.components.persistent_notification import .... Every other usage of this import in coordinator.py is scoped to an async def method. Commit 2adf405 explicitly fixed the same pattern in binary_sensor.py citing inconsistency — this reintroduces it in sync callbacks that fire on every GPS state change.

GPS2ASP-Resolver/custom_components/asp_parking/coordinator.py

Lines 1615 to 1630 in efcd067

	pn_dismiss(self.hass, "asp_parking_gps_stale")
	delay = float(self.stale_timeout * 3600)
	@callback
	def _on_gps_stale(_now: datetime) -> None:
	from homeassistant.components.persistent_notification import (
	async_create as pn_create,
	)
	pn_create(
	self.hass,
	f"No GPS update has been received for {self.stale_timeout} hour(s). "
	"The GPS pipeline health sensor is now OFF. Check that your device "
	"tracker is reporting location updates.",
	title="ASP Parking: GPS Signal Lost",

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}