Repository navigation
Conversation
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChunkKVPresscomputes chunk scores for every example but previously applied the first example's selected chunks to the entire batch. Select and gather chunks independently for each example so a later example keeps its own high-scoring tokens.If selection of a trailing partial chunk gives examples different retained lengths, raise a clear error: the dense cache tensor cannot represent that ragged result. Single-example partial chunks and batches with equal retained lengths continue to work.
Fixes #317.
Validation
make stylepassed, including flake8, mypy, and SPDX checks; Black and isort checks passed for changed files.