Repository navigation
[cudax] Rename make_cg_equivalent_group to make_group - #12070
Conversation
📝 Summary
Priority: ⬇️ Low Change: Refactor Merge Risk: 🔵 Low · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments: 1
cudax/include/cuda/experimental/coop/__group/make_group.cuh: 1
138-139: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valuesuggestion: The comment contradicts itself. It says CG's
coalesced_groupis not equivalent to CG'scoalesced_group. The second occurrence presumably means the cudaxcoalesced_group. Fix the wording.
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: NVIDIA/cccl/.coderabbit.yaml
- Review profile: CHILL
- Plan: Enterprise
- Run ID:
ac952310-14a3-4138-ae98-3218404d4d71
📒 Files selected for processing: 5
cudax/include/cuda/experimental/coop/__group/cg_interop.cuhcudax/include/cuda/experimental/coop/__group/fwd.cuhcudax/include/cuda/experimental/coop/__group/make_group.cuhcudax/include/cuda/experimental/coop/groupcudax/test/coop/group/cg_interop.cu
💤 Files with no reviewable changes: 2
- cudax/include/cuda/experimental/coop/group
- cudax/include/cuda/experimental/coop/__group/cg_interop.cuh
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
🥳 CI Workflow Results🟩 Finished in 3h 02m: Pass: 100%/73 | Total: 1d 07h | Max: 1h 08m | Hits: 19%/269753See results here. AI failure analysis1. MatX host example GCC module-dependency warning promoted to error · 1 jobExplanation: CMake scanned `test_host.cpp` for C++ module dependencies, then GCC 14.3 rejected the generated module-dependency compilation under `-Werror`; the command already contained `-MD`, so the note indicates a toolchain or launcher interaction rather than a missing application flag. The PR changes only cudax cooperative-group headers and tests, and the compiler failed at `<built-in>` before reporting any CCCL source diagnostic, so the available evidence does not connect the failure to the API rename. Evidence: Copy this prompt into a coding agentJobs: |
Since we now have the
cudax::coop::make_groupfactory function, I think we should merge it with thecudax::coop::make_cg_equivalent_groupfunction.