Repository navigation
Conversation
HAVE_CTYPE_H is often left unset in config.h even though ctype.h is ISO C. C99 then rejects the implicit isprint() declaration used by FIELD_TFF (notably under emscripten/WASM). * src/dec_macros.h: Include <ctype.h> unconditionally.
Contributor
|
emscripten doesn't find the header in the probes? Does for me, with both emconfigure and cmake |
Contributor
|
Thanks, applied to master. I cannot reproduce the missing HAVE_CTYPE_H: with emsdk 4.0.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1531.
FIELD_TFFusesisprint(), butctype.hwas only included whenHAVE_CTYPE_H/_MSC_VERwas set. That breaks C99 builds (notably emscripten) when autoconf leavesHAVE_CTYPE_Hunset.Change
Include
<ctype.h>unconditionally.Test plan
HAVE_CTYPE_Hundefined and confirmFIELD_TFFcompiles