Repository navigation
spec: guard MPOLYGON spline fitpts like HATCH - #1535
Merged
Merged
Conversation
HATCH already skips fitpts/tangents when num_fitpts is 0. MPOLYGON still called FIELD_2RD_VECTOR on a zero count (VALUEOUTOFBOUNDS) and omitted the start/end tangents that follow a non-empty fit-point edge. * src/dwg.spec (MPOLYGON): Read fitpts and tangents only when num_fitpts > 0; fix default curve_type assignment to use segx[].
rurban
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1529.
HATCH already skips fitpts/tangents when
num_fitpts == 0. MPOLYGON still calledFIELD_2RD_VECTORon a zero count and omitted the tangents that follow a non-empty fit-point edge.Change
Mirror HATCH: read fitpts + start/end tangents only when
num_fitpts > 0. Also assigncurve_typeviasegx[]in the default arm.Test plan
num_fitpts == 0