Repository navigation
Fixed broken KDoc links, added @ExcludeFromSources - #2201
Conversation
Co-authored-by: Junie <junie@jetbrains.com>
Co-authored-by: Junie <junie@jetbrains.com>
Jolanrensen
changed the title
…opNaNs, ExpressionsGivenColumn, AddDataRowNote) (#2183) Co-authored-by: Junie <junie@jetbrains.com>
a51e91a to
ecfc509
Compare
36d5bde to
bd3e23b
Compare
Co-authored-by: Junie <junie@jetbrains.com>
bd3e23b to
d8c75a4
Compare
![jetbrains-air[bot]](https://avatars.githubusercontent.com/in/3314082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good to me, approving! 🎉
Produced by Air Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=6517a0b8-636a-4045-9171-6a1a642b1ce2
There was a problem hiding this comment.
Thanks, just one blocking item to address before merge!
Produced by Air Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=9301bbfc-cbd7-4dca-9964-70d7d98bfd81
Allex-Nik
left a comment
Allex-Nik
left a comment
There was a problem hiding this comment.
Cool!
I left several notes where I suspect that something could be excluded as well :)
Jolanrensen
changed the title
|
Actually, one more thing: All nested elements inside every |
There was a problem hiding this comment.
Thanks for addressing the feedback, approving! 🎉
Produced by Air Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=0ef824a7-33da-48f2-a5ea-d2a340d50844
|
@Allex-Nik @AndreiKingsley okay I added a bunch more |
bb1fe64 to
eafadf6
Compare
There was a problem hiding this comment.
Looks good, approving! 🎉
Produced by Air Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=b203b43f-863b-4283-95f4-c19709a02a61
|
@Jolanrensen be careful do not exclude the whole library! |
eafadf6 to
f5ac67c
Compare
There was a problem hiding this comment.
Thanks, just one small blocking ktlint fix needed before merge!
Produced by Air Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=dd9fab63-b41e-44d0-be74-ebc0646fd752
There was a problem hiding this comment.
Thanks! Just one blocking item to fix before merge.
Produced by Air Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=479a6e96-8ea1-4519-a178-be1072bc2729
There was a problem hiding this comment.
Thanks, just one blocking item to fix before merge!
Produced by Air Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=39a8aed1-d94f-4c6b-8f16-b8565176c732
f5ac67c to
fddd856
Compare
There was a problem hiding this comment.
Thanks for the fix — all good now, approving! 🎉
Produced by Air Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=6377e034-0165-4957-b3f8-7b68c869d031
Part of #2183.
:dokkaGenerateModuleHtml: unresolved-link warnings dropped from ~1300 to ~400.Fixes #605
@ExcludeFromSourceswere added, some removed.@param [col\]-> correct param names invalueCol/frameCol/colGroup[Iterable.contains]->[kotlin.collections.contains];SingleColumn.except->ColumnsSelectionDsl.except;@see [cols\]in all.kt.