Repository navigation
[2.x] chore: update JS tooling (flarum-webpack-config ^3.1.0, webpack-cli ^7.2.3, typescript ^5.9.3) - #19
Merged
Conversation
…7.2.3, typescript ^5.9.3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Brings the JS tooling in line with flarum/framework and
@flarum/cli:flarum-webpack-config:^3.0.7→^3.1.0webpack-cli:^4.9.1→^7.2.3typescript:^4.5.4→^5.9.3typescriptis declared directly sotscstays linked under package managers that only link the binaries of direct dependencies.webpack-cli7 needs Node 20.9 or later.yarn.lockis updated without a full regeneration.No release needed: the rebuilt bundle is not expected to change.
Reviewers should focus on:
No source changes.
yarn check-typings,yarn format-checkandyarn buildpass.check-typingsnow runs on TypeScript 5.9 instead of 4.9.regenerateis deduplicated to 1.5.0, as jest-config's README recommends, so Babel does not end up with two copies. Also removes the stalejs/package-lock.json: the frontend workflow already installs with yarn (js_package_manager: yarn), andyarn.lockis the lockfile it uses.Confirmed
yarn testinjs/).