Skip to content

Misc. simplifications to ACL permissions - #3949

Merged
eldering merged 5 commits into
mainfrom
permission-fixes
Nov 19, 2026
Merged

eldering merged 5 commits into
mainfrom
permission-fixes

Conversation

@eldering

@eldering eldering commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Mostly to not clutter ls output, so that it's clearer what files actually have special permissions.

See individual commits for details.

This was added in ee5b197, but isn't needed: each `setfacl -m u:...`
already recalculates the default mask to cover the named entries,
so the writable directories end up with `mask::rwx` anyway.

It also cannot fix files created later (e.g. by `import-contest`):
their mask comes from the mode they are created with, not from a
one-time `setfacl` at install. Applying it to the whole checkout
only makes every file look `group:rwx` (including the `etc/*.secret`
files) and potentially hides real permission issues.
This reverts dedc731. If some process changes
the permissions on this file, we should fix that.
That makes sure only directories inherit the execute/search
permission bit, not regular files, which don't need it.
The default mask is already calculated from all named
ACL entries, so this doesn't change anythin.
We don't need default x, just on the directories so that
WEBSERVER_GROUP has traversal on these. Do add r on the
final `doc/manual/build` so that if `domjudge-team-manual.pdf`
gets rebuild, it will inherit WEBSERVER_GROUP readable
again.

Also drop recursive flag for file `domjudge-team-manual.pdf`.
@eldering
eldering added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit e685fe9 Nov 19, 2026
47 checks passed
@eldering
eldering deleted the permission-fixes branch November 19, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants