Repository navigation
Misc. simplifications to ACL permissions - #3949
Merged
Merged
Conversation
This was added in ee5b197, but isn't needed: each `setfacl -m u:...` already recalculates the default mask to cover the named entries, so the writable directories end up with `mask::rwx` anyway. It also cannot fix files created later (e.g. by `import-contest`): their mask comes from the mode they are created with, not from a one-time `setfacl` at install. Applying it to the whole checkout only makes every file look `group:rwx` (including the `etc/*.secret` files) and potentially hides real permission issues.
This reverts dedc731. If some process changes the permissions on this file, we should fix that.
That makes sure only directories inherit the execute/search permission bit, not regular files, which don't need it.
The default mask is already calculated from all named ACL entries, so this doesn't change anythin.
We don't need default x, just on the directories so that WEBSERVER_GROUP has traversal on these. Do add r on the final `doc/manual/build` so that if `domjudge-team-manual.pdf` gets rebuild, it will inherit WEBSERVER_GROUP readable again. Also drop recursive flag for file `domjudge-team-manual.pdf`.
meisterT
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly to not clutter
lsoutput, so that it's clearer what files actually have special permissions.See individual commits for details.