Repository navigation
Conversation
Member
|
This does mask it in the overview/list, but does it also mask it in the detail view? |
Member
|
had another look, seems we need to touch |
It looks ugly in some cases and less professional in others where printing happened much earlier. The exact time is not relevant and could lead to discussions with teams. This also clarifies some parameters in the function call and re-orders to make the conditions a bit easier to follow by returning early.
Member
Author
Either I already adressed this or I don't know what you're talking about. Can you send a screenshot where you think this is wrong? |
vmcj
force-pushed
the
absolute_clarifications
branch
from
November 21, 2026 07:02
a4de788 to
83b3a3a
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

It looks ugly in some cases and less professional in others where printing happened much earlier. The exact time is not relevant and could lead to discussions with teams.
This also clarifies some parameters in the function call and re-orders to make the conditions a bit easier to follow by returning early.
Work to close: #3174
If we want I can split out the re-order to its own commit as they're not strongly coupled.