Skip to content

Don't display clarification time from before contest - #3882

Open
vmcj wants to merge 1 commit into
DOMjudge:mainfrom
vmcj:absolute_clarifications
Open

vmcj wants to merge 1 commit into
DOMjudge:mainfrom
vmcj:absolute_clarifications

Conversation

@vmcj

@vmcj vmcj commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

It looks ugly in some cases and less professional in others where printing happened much earlier. The exact time is not relevant and could lead to discussions with teams.

This also clarifies some parameters in the function call and re-orders to make the conditions a bit easier to follow by returning early.

Work to close: #3174

If we want I can split out the re-order to its own commit as they're not strongly coupled.

@meisterT

Copy link
Copy Markdown
Member

This does mask it in the overview/list, but does it also mask it in the detail view?

@meisterT

meisterT commented Nov 8, 2026

Copy link
Copy Markdown
Member

had another look, seems we need to touch printtimeHover as well

It looks ugly in some cases and less professional in others where printing
happened much earlier. The exact time is not relevant and could lead to
discussions with teams.

This also clarifies some parameters in the function call and re-orders
to make the conditions a bit easier to follow by returning early.
@vmcj

vmcj commented Nov 21, 2026

Copy link
Copy Markdown
Member Author

had another look, seems we need to touch printtimeHover as well

Either I already adressed this or I don't know what you're talking about. Can you send a screenshot where you think this is wrong?

@vmcj
vmcj force-pushed the absolute_clarifications branch from a4de788 to 83b3a3a Compare November 21, 2026 07:02
@meisterT

Copy link
Copy Markdown
Member
image

I think it would also be OK to have it, just wanted to make sure we are making a deliberate choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants