Skip to content
This repository was archived by the owner on Aug 21, 2022. It is now read-only.
This repository was archived by the owner on Aug 21, 2022. It is now read-only.

prob01-poker question thread #3

Closed

Description

@zmughal

Ask for clarifications about the problem here.

Activity

  1. zmughal commented on Sep 16, 2014

    @zmughal
    MemberAuthor

    @Inseighn, if you would like to ask about branching here instead of #4, it will be more visible (maybe).

  2. StefanoFiumara commented on Sep 17, 2014

    @StefanoFiumara

    When checking for a straight, can an Ace be both a low card and a high card? e.g. is A-2-3-4-5 a valid straight, or can the ace only be used in a 10-J-Q-K-A sequence?

  3. Inseighn commented on Sep 17, 2014

    @Inseighn
    Contributor

    Must I create a new pull request after each commit/code change for it to be visible?

  4. zmughal commented on Sep 17, 2014

    @zmughal
    MemberAuthor

    @Inseighn , nope, you just keep on committing! That's the advantage of using a branch for each problem

    @StefanoFiumara, according to Wikipedia: "the ace may not "wrap around", or play both high and low".

  5. StefanoFiumara commented on Sep 17, 2014

    @StefanoFiumara

    Right, no wrapping, but the Ace can still be the low card in a straight like A-2-3-4-5, which is a special case that I must test for..

  6. zmughal commented on Sep 17, 2014

    @zmughal
    MemberAuthor

    Oh, ha, I see. Didn't have my caffeine yet when I wrote that... @zeebo404, want to update the problem statement to include this?

  7. devzeebo commented on Sep 17, 2014

    @devzeebo
    Member

    Yes, the Ace can be low, but ONLY in straights or straight flushes (A-2-3-4-5)

  8. zmughal commented on Sep 18, 2014

    @zmughal
    MemberAuthor

    I updated the spec.

  9. StefanoFiumara commented on Sep 18, 2014

    @StefanoFiumara

    What is the order by which suits are to be sorted? I always thought it was Hearts -> Diamonds -> Clubs -> Spades, but the problem description has them in a different order.

    edit: wiki says most poker variations don't rank suits in a specific order, so this may be irrelevant.

  10. zmughal commented on Sep 18, 2014

    @zmughal
    MemberAuthor

    Ah, OK. :-)

    I have some more data in my repo, if anyone wants to use it https://github.com/zmughal/code-reviews/blob/prob01-poker/zmughal/prob01-poker/expect.txt.

  11. zmughal commented on Oct 8, 2014

    @zmughal
    MemberAuthor

    Hey everyone, there's a new problem up (prob02-word-chains). You can continue to work on the poker problem of course. See it to the end!

  12. locked and limited conversation to collaborators on Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions