Repository navigation
Strip markup from post type and meta filter aria-labels - #4410
Merged
Merged
Conversation
When Display Term Count is on, the visible label includes the count wrapped in a <span>. That same label was used to build the link's aria-label, so the escaped markup ended up in the accessible name, e.g. "Apply filter: Product <span>(18)</span>". Strip tags before building the accessible label so screen readers announce "Apply filter: Product (18)".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
When "Display Term Count" is enabled on the Filter by Post Type or Filter by Metadata blocks, the visible label includes the count wrapped in a
<span>. The same label was reused to build the link'saria-label, so the escaped markup ended up in the accessible name:This change strips tags from the label before building the accessible label (both "Apply filter" and "Remove filter"), so screen readers announce
Apply filter: Product (18). The visible label is unchanged and still renders the<span>. Labels customized throughep_facet_post_type_value_label/ep_facet_meta_value_labelget the same treatment. The taxonomy facet already builds its accessible label from the plain term name, so it is not affected.How to test the Change
/shop/or a search results page) and inspect a filter link.aria-label="Apply filter: Product <span>(18)</span>". After:aria-label="Apply filter: Product (18)".Remove filter: Product (18).Apply filter: Product.Changelog Entry
Credits
Props @burhandodhy
Checklist: