Repository navigation
Sync: End the sync when a batch comes back empty - #4408
Merged
felipeelia merged 1 commit intoNov 10, 2026
Merged
Conversation
When a batch had no objects but the offset had not reached the total, the sync read ->ID from false, reset the pagination cursor and started over from the first object. With a batch query that never returned objects it looped forever. Co-Authored-By: Claude <noreply@anthropic.com>
|
Privileged e2e (EP.io and @paidPlugins) started for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
When a sync batch comes back empty before the offset reaches the total (e.g. a post is published mid-sync), the sync reads
->IDfromfalse, resets its cursor and starts over from the first object, and loops forever if the batch query never returns anything. This ends the sync on an empty batch instead.How to test the Change
composer run test-single-site -- --filter TestIndexHelper(the new test fails without the change).Changelog Entry
Credits
Props @rebeccahum
Checklist:
🤖 Generated with Claude Code