From 62557ede7ea557e2a4931ab64b30854cf4865796 Mon Sep 17 00:00:00 2001 From: hanjinpeng Date: Thu, 22 Oct 2026 07:20:50 -0400 Subject: [PATCH] Fix memory leak on XML generation error in comps_docgroup_xml() The localized name/description string was only freed after the error check of xmlTextWriterWriteString(), so it leaked when writing failed. Signed-off-by: hanjinpeng --- libcomps/src/comps_docgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcomps/src/comps_docgroup.c b/libcomps/src/comps_docgroup.c index 6f89ed6..12e44a5 100644 --- a/libcomps/src/comps_docgroup.c +++ b/libcomps/src/comps_docgroup.c @@ -351,8 +351,8 @@ signed char comps_docgroup_xml(COMPS_DocGroup *group, xmlTextWriterPtr writer, COMPS_XMLRET_CHECK(comps_hslist_destroy(&pairlist)) str = tostrf[i](((COMPS_ObjRTreePair*)hsit->data)->data); ret = xmlTextWriterWriteString(writer, (xmlChar*)str); - COMPS_XMLRET_CHECK(comps_hslist_destroy(&pairlist)) free(str); + COMPS_XMLRET_CHECK(comps_hslist_destroy(&pairlist)) ret = xmlTextWriterEndElement(writer); COMPS_XMLRET_CHECK(comps_hslist_destroy(&pairlist)) }