Repository navigation
[RN][Changelog] Mark two v0.89.0-rc.0 entries as breaking - #59810
Merged
Merged
Conversation
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D129979450. |
Collaborator
|
This pull request was successfully merged by @fabriziocucci in 1f7be0b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Moves two v0.89.0-rc.0 changelog entries to Breaking. Both stop existing libraries from building without a change on their side, as found while upgrading Expo to 0.89.0-rc.0 (expo/expo#52979):
invokeJavaMethodoverload fails the build of libraries that ship pre-generated JNI codegen, because codegen CMake builds with-Werror(react-native-svg 15.16.0, react-native-maps 1.29.11).RCTBridgeModule.h#59405 was under Changed.constantsToExportis now nonnull, so Swift overrides declared-> [AnyHashable : Any]!no longer compile (lottie-react-native 7.5.0).The entries also say what to change.
Changelog:
[INTERNAL] - Mark two v0.89.0-rc.0 changelog entries as breaking
Test Plan:
N/A, changelog only. The diff moves the two entries and removes one blank line; the rest of
CHANGELOG.mdis unchanged.