Skip to content

Support pnpm; add Next.js #1017

Open

Description

@GeoffreyBooth

I’d like to add Next.js to CITGM. It uses pnpm to install dependencies, and before its tests can run it needs to be built. See https://github.com/vercel/next.js/blob/canary/contributing/core/developing.md.

Can we add support for pnpm like we do for yarn? And also another flag like build: true that when set runs <npm/yarn/pnpm> run build before running <npn/yarn/pnpm> test?

cc @Ethan-Arrowood

Activity

  1. targos commented on Oct 21, 2023

    @targos
    Member

    pnpm: sure if someone contributes it
    Build script: already possible. You can provide an array of scripts to run.

  2. Ethan-Arrowood commented on Nov 8, 2023

    @Ethan-Arrowood

    FYI I've made relative teams aware of this internally at Vercel. I'll do my best to facilitate someone to assist with adding Next.js once pnpm is supported.

  3. changed the title [-]Support pnpm; support build step[/-] [+]Support pnpm; add Next.js[/+] on Nov 12, 2023
  4. Ethan-Arrowood commented on Jan 9, 2024

    @Ethan-Arrowood

    For cross reference, adding Next.js to CITGM will help deter events such as: nodejs/node#50269

  5. added a commit that references this issue on Jan 9, 2024
  6. styfle commented on Jan 9, 2024

    @styfle
    SponsorMember

    I created a PR here: #1044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions