Repository navigation
Update to GPUEnv 0.3 - #47
Merged
Merged
Conversation
Benchmark Results (Julia v1.13.1)🐢 2 time regressions detected Time benchmarks
Memory benchmarks
|
JET 0.12 is the release series for Julia 1.13. Capped at 0.11, the test environment resolved JET 0.11.6 on Julia 1.13, which does not constant-fold `Base.dotgetproperty`, the lowering of `op.buf .= x`: it reported a runtime dispatch on every such field broadcast (NfftNormalOp's mul!) and on Hankel's keyword constructor, where native inference and JET 0.12.2 find none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI's Documenter build failed cross-reference resolution on [estimate_opnorm](@ref) inside opnorm's docstring, even though both are documented on the same docs page (docs/src/properties.md) -- passes locally with the pinned Documenter 1.17.0 but not with whatever version CI resolves fresh against docs/Project.toml's "1.8" compat bound. Same failure mode and fix as 7df169f: replace the fragile @ref with a plain code span. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AcceleratedDCTs plans call synchronize on the array's KernelAbstractions backend, which JLArrays does not implement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….11+ Without it, every backend was skipped and the test item passed with no checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 51 51
Lines 3678 3678
=======================================
Hits 3315 3315
Misses 363 363 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPUEnv 0.3 renamed
include_jlarraystoinclude_cpu_backends; the test project had no GPUEnv compat bound, so it already resolves 0.3 and the DSP/FFTW GPU tests fail with an unsupported keyword. The DSP and DFT GPU tests drop the keyword (supports_fftw = trueis enough, and JLArray passes them on Julia 1.11+); the DCT test and the benchmark use the new name, since AcceleratedDCTs does not support JLArrays. The test project getsGPUEnv = "0.3".🤖 Generated with Claude Code