Issue with Notification Class After Commit 0e49323

[BerNarDoMelow]

Hi!

After the changes in commit 0e49323, we started encountering an issue due to the following modification:
notifier.const_set :Notification, Class.new(const_defined?(:Notification) ? const_get(:Notification) : Noticed::Notification)

The problem arises because we already have a class named Notification. For example:

> notifier.const_set :Notification, Class.new(Noticed::Notification).table_name
=> "noticed_notifications"

> notifier.const_set :Notification, Class.new(const_defined?(:Notification) ? const_get(:Notification) : Noticed::Notification).table_name
=> "notifications"

This change is causing conflicts in our application. Is there a recommended workaround for this?

Thanks in advance for your help!

Note: In the meantime, I came across this discussion (#516), but in our case, renaming our Notification model is not an option.

[guillaumecabanel]

hey @BerNarDoMelow , I came across the same issue and fixed it with this:

class ApplicationNotifier < Noticed::Event
+  remove_const "Notification"
+  Notification = Class.new(Noticed::Notification)
end

[BerNarDoMelow]

hey @guillaumecabanel , thanks a lot! that fix worked perfectly, really appreciate you sharing it 🙌