From ee5b465decbe237db7b1d95b3766b3e7ee5a38ef Mon Sep 17 00:00:00 2001 From: Alex Kanitz Date: Mon, 16 Nov 2026 06:44:24 +0100 Subject: [PATCH] ci: fail the scheduled image scan again Drop fail: "false" from scan.yml now that 0.12.0 published latest through the release workflow and its scan has no critical or high findings. Update the header comment and the note in development.md. Closes #158 Co-Authored-By: Claude Opus 5.5 --- .github/workflows/scan.yml | 10 +++------- docs/development.md | 10 +++------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/.github/workflows/scan.yml b/.github/workflows/scan.yml index 1f556b5..69e9ce2 100644 --- a/.github/workflows/scan.yml +++ b/.github/workflows/scan.yml @@ -4,12 +4,9 @@ # a release are reported: the findings that have a fix are uploaded to code # scanning, and a full report (findings without a fix included) is uploaded as # the workflow artifact `trivy-report-release-image-` (JSON and table). -# Accepted findings are listed in `.trivyignore.yaml`. Doesn't fail on -# findings until the first release of `release.yml`: until then, `latest` is -# the image that the old tag workflows published for v0.10.6. Drop -# `fail: "false"` once a release has published `latest`, so that it fails on -# critical and high vulnerabilities that have a fix (fixed by a new release), -# as CI, `release.yml` and tesk-api do. Scheduled runs use this workflow (with +# Accepted findings are listed in `.trivyignore.yaml`. Fails on critical and +# high vulnerabilities that have a fix (fixed by a new release), as CI, +# `release.yml` and tesk-api do. Scheduled runs use this workflow (with # its pin of the shared action `elixir-cloud-aai/.github/actions/scan-image`) # and `.trivyignore.yaml` as on the default branch, and file their findings # under it. The images are public, so no Docker Hub secrets are needed; their @@ -51,4 +48,3 @@ jobs: image: docker.io/${{ vars.DOCKERHUB_ORG || 'elixircloud' }}/tesk-core-${{ matrix.image }}:latest category: release-image-${{ matrix.image }} report: "true" - fail: "false" diff --git a/docs/development.md b/docs/development.md index dd0d0a7..00d0133 100644 --- a/docs/development.md +++ b/docs/development.md @@ -146,10 +146,9 @@ Hub organization if it sets the variable `DOCKERHUB_ORG`. The workflow `Scan` (`.github/workflows/scan.yml`) scans the `latest` images weekly, so that vulnerabilities found after a release are reported to code -scanning, with a full report as a workflow artifact. Until the first release -of the release workflow below, `latest` is still the image of v0.10.6 from -the old tag workflows, and the scan only reports; after that release, it -fails on critical and high vulnerabilities that have a fix. +scanning, with a full report as a workflow artifact. It fails on critical +and high vulnerabilities that have a fix (except those accepted in +`.trivyignore.yaml`): release a new version to fix them. ## Versioning and releases @@ -222,9 +221,6 @@ are released at once, GitHub can cancel a waiting run of the job: re-run it the same way. Releases are never edited afterwards: fix mistakes in the notes of the next release. -After the first release of this workflow, drop `fail: "false"` in -`.github/workflows/scan.yml`, and the note on it above. - ## Dependencies and metadata Dependabot (`.github/dependabot.yml`) opens grouped pull requests to `dev`