From a72352ae5404957473bfc985d885ec44fedfcbdb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 19 Oct 2026 09:14:57 +0000 Subject: [PATCH 1/2] chore(deps): bump the all-other-cargo-deps group across 1 directory with 9 updates Bumps the all-other-cargo-deps group with 9 updates in the / directory: | Package | From | To | | --- | --- | --- | | [serde_json](https://github.com/serde-rs/json) | `1.0.151` | `1.0.154` | | [sha2](https://github.com/RustCrypto/hashes) | `0.11.0` | `0.11.1` | | [tokio](https://github.com/tokio-rs/tokio) | `1.53.1` | `1.53.3` | | [tokio-util](https://github.com/tokio-rs/tokio) | `0.7.19` | `0.7.20` | | [uuid](https://github.com/uuid-rs/uuid) | `1.27.0` | `1.28.0` | | [zstd](https://github.com/gyscos/zstd-rs) | `0.14.0` | `0.14.2` | | [twox-hash](https://github.com/shepmaster/twox-hash) | `2.1.4` | `2.1.5` | | [async-recursion](https://github.com/dcchut/async-recursion) | `1.1.1` | `1.2.0` | | [syn](https://github.com/dtolnay/syn) | `3.0.6` | `3.0.9` | Updates `serde_json` from 1.0.151 to 1.0.154 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](https://github.com/serde-rs/json/compare/v1.0.151...v1.0.154) Updates `sha2` from 0.11.0 to 0.11.1 - [Commits](https://github.com/RustCrypto/hashes/compare/sha2-v0.11.0...sha2-v0.11.1) Updates `tokio` from 1.53.1 to 1.53.3 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.53.1...tokio-1.53.3) Updates `tokio-util` from 0.7.19 to 0.7.20 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](https://github.com/tokio-rs/tokio/compare/tokio-util-0.7.19...tokio-util-0.7.20) Updates `uuid` from 1.27.0 to 1.28.0 - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](https://github.com/uuid-rs/uuid/compare/v1.27.0...v1.28.0) Updates `zstd` from 0.14.0 to 0.14.2 - [Release notes](https://github.com/gyscos/zstd-rs/releases) - [Commits](https://github.com/gyscos/zstd-rs/compare/v0.14.0...v0.14.2) Updates `twox-hash` from 2.1.4 to 2.1.5 - [Changelog](https://github.com/shepmaster/twox-hash/blob/main/CHANGELOG.md) - [Commits](https://github.com/shepmaster/twox-hash/compare/v2.1.4...v2.1.5) Updates `async-recursion` from 1.1.1 to 1.2.0 - [Release notes](https://github.com/dcchut/async-recursion/releases) - [Commits](https://github.com/dcchut/async-recursion/compare/v1.1.1...v1.2.0) Updates `syn` from 3.0.6 to 3.0.9 - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](https://github.com/dtolnay/syn/compare/3.0.6...3.0.9) --- updated-dependencies: - dependency-name: serde_json dependency-version: 1.0.154 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-other-cargo-deps - dependency-name: sha2 dependency-version: 0.11.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-other-cargo-deps - dependency-name: tokio dependency-version: 1.53.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-other-cargo-deps - dependency-name: tokio-util dependency-version: 0.7.20 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-other-cargo-deps - dependency-name: uuid dependency-version: 1.28.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-other-cargo-deps - dependency-name: zstd dependency-version: 0.14.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-other-cargo-deps - dependency-name: twox-hash dependency-version: 2.1.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-other-cargo-deps - dependency-name: async-recursion dependency-version: 1.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-other-cargo-deps - dependency-name: syn dependency-version: 3.0.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-other-cargo-deps ... Signed-off-by: dependabot[bot] --- Cargo.lock | 61 +++++++++++++++++++++++++++--------------------------- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 47b2d0fb1051a..8f70734c4839b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -485,13 +485,13 @@ checksum = "39cd9de47399986d5b216c6bef9434dfff1689ab61ba8d1e2720dc5fe5c84083" [[package]] name = "async-recursion" -version = "1.1.1" +version = "1.2.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "3b43422f69d8ff38f95f1b2bb76517c91589a924d1559a0e935d7c8ce0274c11" +checksum = "4f8abc12baad266b1c8cec146854c195b5864b4221d4b2ca7296a7ae82d9e451" dependencies = [ "proc-macro2", "quote", - "syn 2.0.119", + "syn 3.0.9", ] [[package]] @@ -524,7 +524,7 @@ checksum = "82f6aeea286b8eb4dd3431a1be1b59d290ace00f5bfd8e2a159bc2a05e2c1667" dependencies = [ "proc-macro2", "quote", - "syn 3.0.6", + "syn 3.0.9", ] [[package]] @@ -1349,7 +1349,7 @@ dependencies = [ "heck", "proc-macro2", "quote", - "syn 3.0.6", + "syn 3.0.9", ] [[package]] @@ -2409,7 +2409,7 @@ version = "55.1.0" dependencies = [ "datafusion-doc", "quote", - "syn 3.0.6", + "syn 3.0.9", ] [[package]] @@ -3219,7 +3219,7 @@ checksum = "9fb9654ba8355388abeb8dcb4fc62f511300867002afc858860463bdd9fe0c44" dependencies = [ "proc-macro2", "quote", - "syn 3.0.6", + "syn 3.0.9", ] [[package]] @@ -5788,7 +5788,7 @@ checksum = "e7a5d71263a5a7d47b41f6b3f06ba276f10cc18b0931f1799f710578e2309348" dependencies = [ "proc-macro2", "quote", - "syn 3.0.6", + "syn 3.0.9", ] [[package]] @@ -5804,10 +5804,11 @@ dependencies = [ [[package]] name = "serde_json" -version = "1.0.151" +version = "1.0.154" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c841b55ecdae098c80dcae9cf767f6f8a0c2cdb3416bbef72181df4d0fe73f14" +checksum = "e7e9cc8b1b85264074fbcc02a88680c4096b1e47df8f739dceb03bf482f04bd6" dependencies = [ + "foldhash 0.2.0", "indexmap 2.14.2", "itoa", "memchr", @@ -5929,9 +5930,9 @@ dependencies = [ [[package]] name = "sha2" -version = "0.11.0" +version = "0.11.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "446ba717509524cb3f22f17ecc096f10f4822d76ab5c0b9822c5f9c284e825f4" +checksum = "47d7069beb7d6ac7b9acd1039986e73443f24234f41074da099d6f994ac9ad19" dependencies = [ "cfg-if", "cpufeatures 0.3.0", @@ -6099,7 +6100,7 @@ checksum = "2905ae8e8148d8f7f5748ea95d1e949fa4fc1d7f5161547b758ad118b2e4b0aa" dependencies = [ "proc-macro2", "quote", - "syn 3.0.6", + "syn 3.0.9", ] [[package]] @@ -6278,9 +6279,9 @@ dependencies = [ [[package]] name = "syn" -version = "3.0.6" +version = "3.0.9" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8593e8e72159ed2257d083c7a454a85cbf854f37a0966d8d483aff8c8a3ebcee" +checksum = "d78c8dee4c7bf0e14673097256fed6142ce9d3b85a408189d07482442145823b" dependencies = [ "proc-macro2", "quote", @@ -6403,7 +6404,7 @@ checksum = "fe5197923287db20a58125f0bc85c062f7f2c892de97b18c356f9efb14b28524" dependencies = [ "proc-macro2", "quote", - "syn 3.0.6", + "syn 3.0.9", ] [[package]] @@ -6492,9 +6493,9 @@ checksum = "1f3ccbac311fea05f86f61904b462b55fb3df8837a366dfc601a0161d0532f20" [[package]] name = "tokio" -version = "1.53.1" +version = "1.53.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "202caea871b69668250d242070849eb495be178ed697a3e98aebce5bc81a0bed" +checksum = "ce3335fa71841cda333a58d7615b03901380ecf09d59b3296d21f8bbac0dde4e" dependencies = [ "bytes", "libc", @@ -6568,9 +6569,9 @@ dependencies = [ [[package]] name = "tokio-util" -version = "0.7.19" +version = "0.7.20" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "494815d09bf52b5548659851081238f0ca39ff638363907596da739561c62c52" +checksum = "e464cf451ba96ebfc6f9b6542f17ee8b8956e33f1e40d9690624e59d7a7f8a4b" dependencies = [ "bytes", "futures-core", @@ -6789,9 +6790,9 @@ checksum = "e421abadd41a4225275504ea4d6566923418b7f05506fbc9c0fe86ba7396114b" [[package]] name = "twox-hash" -version = "2.1.4" +version = "2.1.5" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "5283634e518fe9e82c7b20520bb4bc209009fd16c82077c802f8111ecbb0117a" +checksum = "86a801b3cea342a06d468c8710662aa29e5e05e4f5c0d62f00bbb7f2ad7941c2" dependencies = [ "rand 0.10.1", ] @@ -6984,9 +6985,9 @@ checksum = "06abde3611657adf66d383f00b093d7faecc7fa57071cce2578660c9f1010821" [[package]] name = "uuid" -version = "1.27.0" +version = "1.28.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "97277d36b9c3ace13e58fa6e753f8b0bbbf302a18dd193240d70f9e29681059a" +checksum = "7cc1186384beb7dd8eedea376413fd654937285ea6c9cfbb928dc3043ea4b606" dependencies = [ "getrandom 0.4.2", "js-sys", @@ -7735,27 +7736,27 @@ checksum = "b8848ee67ecc8aedbaf3e4122217aff892639231befc6a1b58d29fff4c2cabaa" [[package]] name = "zstd" -version = "0.14.0" +version = "0.14.2" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "bf06bd8162af0734b344780deb55b42a2429ae430870d13fcc12f238e880fe6e" +checksum = "057cfd910cfac363a0ada849592624b4c9ff2e10bef504c3433810d78ed96f93" dependencies = [ "zstd-safe", ] [[package]] name = "zstd-safe" -version = "8.0.0" +version = "8.2.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "ae42c0555055784c70058d19ba8e275528e8a99a706684868ace5da4e716a4ab" +checksum = "ded520f16b29e1a9b771c722221b2b0a0398c2316d9bb3c42b458a5414d7434b" dependencies = [ "zstd-sys", ] [[package]] name = "zstd-sys" -version = "2.1.0+zstd.1.5.7" +version = "2.1.2+zstd.1.5.7" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "0ef0a8027ec3ee71300ab3bcbcd0393f434aa72b91ca6d635a39941deae8eea0" +checksum = "481ada9c543b2323cbb7bbdbb5249177fbf0188ed959ed2c15e4b22421c84ed3" dependencies = [ "cc", "pkg-config", From ae65c2fc6beeeebd79888500ee7d13408b8b0fa6 Mon Sep 17 00:00:00 2001 From: Neil Conway Date: Mon, 19 Oct 2026 11:18:15 -0400 Subject: [PATCH 2/2] chore: remove double_must_use expects for async-recursion 1.2 async-recursion 1.2.0 no longer adds `#[must_use]` to the functions it rewrites. Clippy's `double_must_use` lint therefore stops firing on the five `#[async_recursion]` functions in datafusion-substrait, and their `#[expect(clippy::double_must_use)]` attributes fail as unfulfilled lint expectations under `-D warnings`. Remove the five expectations, and require async-recursion 1.2 so that the declared version matches the code's lint assumptions. --- datafusion/substrait/Cargo.toml | 2 +- .../substrait/src/logical_plan/consumer/rel/fetch_rel.rs | 4 ---- .../substrait/src/logical_plan/consumer/rel/filter_rel.rs | 4 ---- datafusion/substrait/src/logical_plan/consumer/rel/mod.rs | 4 ---- .../substrait/src/logical_plan/consumer/rel/project_rel.rs | 4 ---- datafusion/substrait/src/physical_plan/consumer.rs | 4 ---- 6 files changed, 1 insertion(+), 21 deletions(-) diff --git a/datafusion/substrait/Cargo.toml b/datafusion/substrait/Cargo.toml index d6403da052266..ec48ef5bec6d1 100644 --- a/datafusion/substrait/Cargo.toml +++ b/datafusion/substrait/Cargo.toml @@ -34,7 +34,7 @@ rust-version = { workspace = true } workspace = true [dependencies] -async-recursion = "1.0" +async-recursion = "1.2" async-trait = { workspace = true } chrono = { workspace = true } datafusion = { workspace = true, features = ["sql"] } diff --git a/datafusion/substrait/src/logical_plan/consumer/rel/fetch_rel.rs b/datafusion/substrait/src/logical_plan/consumer/rel/fetch_rel.rs index ebc73a3ee3da9..12a8a77199b1a 100644 --- a/datafusion/substrait/src/logical_plan/consumer/rel/fetch_rel.rs +++ b/datafusion/substrait/src/logical_plan/consumer/rel/fetch_rel.rs @@ -22,10 +22,6 @@ use datafusion::logical_expr::{LogicalPlan, LogicalPlanBuilder, lit}; use substrait::proto::{FetchRel, fetch_rel}; #[async_recursion] -#[expect( - clippy::double_must_use, - reason = "`async_recursion` adds `#[must_use]` to the boxed future it returns" -)] pub async fn from_fetch_rel( consumer: &impl SubstraitConsumer, fetch: &FetchRel, diff --git a/datafusion/substrait/src/logical_plan/consumer/rel/filter_rel.rs b/datafusion/substrait/src/logical_plan/consumer/rel/filter_rel.rs index ac527d95c9701..645b98278208d 100644 --- a/datafusion/substrait/src/logical_plan/consumer/rel/filter_rel.rs +++ b/datafusion/substrait/src/logical_plan/consumer/rel/filter_rel.rs @@ -22,10 +22,6 @@ use datafusion::logical_expr::{LogicalPlan, LogicalPlanBuilder}; use substrait::proto::FilterRel; #[async_recursion] -#[expect( - clippy::double_must_use, - reason = "`async_recursion` adds `#[must_use]` to the boxed future it returns" -)] pub async fn from_filter_rel( consumer: &impl SubstraitConsumer, filter: &FilterRel, diff --git a/datafusion/substrait/src/logical_plan/consumer/rel/mod.rs b/datafusion/substrait/src/logical_plan/consumer/rel/mod.rs index e9b5190606dfa..4328a2a996243 100644 --- a/datafusion/substrait/src/logical_plan/consumer/rel/mod.rs +++ b/datafusion/substrait/src/logical_plan/consumer/rel/mod.rs @@ -50,10 +50,6 @@ use substrait::proto::{Rel, RelCommon, rel_common}; /// Convert Substrait Rel to DataFusion DataFrame #[async_recursion] -#[expect( - clippy::double_must_use, - reason = "`async_recursion` adds `#[must_use]` to the boxed future it returns" -)] pub async fn from_substrait_rel( consumer: &impl SubstraitConsumer, relation: &Rel, diff --git a/datafusion/substrait/src/logical_plan/consumer/rel/project_rel.rs b/datafusion/substrait/src/logical_plan/consumer/rel/project_rel.rs index 74c3b497c086b..589dab9c3b6e3 100644 --- a/datafusion/substrait/src/logical_plan/consumer/rel/project_rel.rs +++ b/datafusion/substrait/src/logical_plan/consumer/rel/project_rel.rs @@ -29,10 +29,6 @@ use std::sync::Arc; use substrait::proto::ProjectRel; #[async_recursion] -#[expect( - clippy::double_must_use, - reason = "`async_recursion` adds `#[must_use]` to the boxed future it returns" -)] pub async fn from_project_rel( consumer: &impl SubstraitConsumer, p: &ProjectRel, diff --git a/datafusion/substrait/src/physical_plan/consumer.rs b/datafusion/substrait/src/physical_plan/consumer.rs index eb971e0a3c95f..3c0df01b4ad38 100644 --- a/datafusion/substrait/src/physical_plan/consumer.rs +++ b/datafusion/substrait/src/physical_plan/consumer.rs @@ -46,10 +46,6 @@ use substrait::proto::{ /// Convert Substrait Rel to DataFusion ExecutionPlan #[async_recursion] -#[expect( - clippy::double_must_use, - reason = "`async_recursion` adds `#[must_use]` to the boxed future it returns" -)] pub async fn from_substrait_rel( _ctx: &SessionContext, rel: &Rel,